Opened 8 months ago

Closed 8 months ago

Last modified 8 months ago

#5537 closed defect (fixed)

Winnie is attempting to use --with-xsldir which is currently not used anymore

Reported by: strk Owned by: robe
Priority: blocker Milestone: PostGIS 3.5.0
Component: QA/buildbots Version: master
Keywords: winnie Cc:

Description

In the current master branch of PostGIS we're not using the --with-xsldir configure switch anymore as we're referencing the XSL by URI instead of looking for a file on the system.

The URI currently used are:

When those URIs are used with xsltproc, the system's XML catalog is queried to map those URIs to files on the system.

A commandline to query the XML catalog for those URIs is:

  • xmlcatalog ${URI}

On my system that works with both URIs. If it doesn't work on Winnie, that means XML catalogs are not in order and some research is needed to find out why.

We used to fail ./configure when not finding the required resources, now we're not failing anymore, I guess we could bring that back to be as nice as before (ref #5533 #5536 ) - if we want to do that, it's better to spin off another ticket

Change History (8)

comment:1 by robe, 8 months ago

I'd rather not waste time spinning wheels on this. Winnie doesn't need to build docs or doing garden testing. She shouldn't need to have docbook at all.

comment:2 by robe, 8 months ago

FWIW my setup is like winnie's.

I did this on my setup: I installed this

pacman -Sy --needed docbook-xml docbook-xsl docbook-xsl-ns

Sadly that did not help and there is no option for

dockbook-xml-5 (docbook-xml seems to be an alias for docbook-xml-4.5

comment:3 by strk, 8 months ago

For the correct way to reference XSL paths see #5538 ( XML_CATALOG_FILES is your friend )

We now also use xmlcatalog which is included in the libxml2-utils package, to give earlier error if URIs cannot be resolved. Maybe install that as well ?

Could you please file tickets with detail about the errors you get ? I'll try to improve the reported error.

comment:4 by robe, 8 months ago

strk so I removed the reference to xsl-dir on my local, and still end with this error:

make[1]: Entering directory '/projects/postgis/postgis-git/utils'
comm -12 postgis_restore_data.hardcoded postgis_restore_data.generated > postgis_restore_data.needlessly-hardcoded
make[1]: Leaving directory '/projects/postgis/postgis-git/utils'
---- Making check-unit in doc
make[1]: Entering directory '/projects/postgis/postgis-git/doc'
# Fail early if cannot find required RelaxNG
xmlcatalog "" "http://docbook.org/xml/5.0/rng/docbook.rng"
No entry for SYSTEM http://docbook.org/xml/5.0/rng/docbook.rng
No entry for URI http://docbook.org/xml/5.0/rng/docbook.rng
make[1]: *** [Makefile:585: check-xml] Error 4
make[1]: Leaving directory '/projects/postgis/postgis-git/doc'
make: *** [GNUmakefile:25: check-unit] Error 1

How can I turn off any kind of doc building? I just want to turn it off.

comment:5 by Regina Obe <lr@…>, 8 months ago

Resolution: fixed
Status: newclosed

In 0027ccc8/git:

Replace winnie's use of xsl-dir with XML_CATALOG_FILES. Closes #5537

comment:6 by robe, 8 months ago

Okay I think I got my system locally working again and copied the same files to winnie. Hopefully that fixes things.

To fix I downloaded - https://docbook.org/xml/5.0.1/docbook-5.0.1.zip

extracted into my /projects/docbook folder

then in winnie's common scripts defined

export XML_CATALOG_FILES="/projects/docbook/docbook-5.0.1/catalog.xml"

comment:7 by Sandro Santilli <strk@…>, 8 months ago

In 119b6e4/git:

Go back to find docbook XSL at configure time

This reverts commit b6583e98323ffe1a8438b51f3a9c70205fdbcf6b
bringing —with-xsldir support back.

Closes #5538 #5539

References #5537

comment:8 by robe, 8 months ago

Note I changed winnie already to not use xsldir. She is now using XML_CATALOG_FILES

Note: See TracTickets for help on using tickets.