Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#4632 closed defect (fixed)

Can't compile against pg13 no such file - utils/jsonapi.h

Reported by: robe Owned by: robe
Priority: blocker Milestone: PostGIS 3.1.0
Component: postgis Version: master
Keywords: Cc:

Description (last modified by robe)

It seems debbie is now unhappy, but her unhappiness I think is unrelated to any changes in PostGIS.

Here pg13 is throwing this during compile

18:41:31 lwgeom_out_geojson.c:20:10: fatal error: utils/jsonapi.h: No such file or directory
18:41:31    20 | #include "utils/jsonapi.h"
18:41:31       |          ^~~~~~~~~~~~~~~~~
18:41:31 compilation terminated.
18:41:31 make[1]: *** [<builtin>: lwgeom_out_geojson.o] Error 1
18:41:31 make[1]: Leaving directory '/var/lib/jenkins/workspace/postgis/branches/3.1/postgis'
18:41:31 make: *** [GNUmakefile:20: all] Error 1
18:41:31 Build step 'Execute shell' marked build as failure
18:41:32 An attempt to send an e-mail to empty list of recipients, ignored.

Seems to have started happening after her build of pg13

https://debbie.postgis.net/job/PG_Version_Dev_Git/5848/
	Changes

    Fail if recovery target is not reached (details)
    Move jsonapi.c and jsonapi.h to src/common. (details)
    Add jsonapi.c to Mkvcbuild.pm's @pgcommonallfiles. (details)

Which corresponds to

https://git.postgresql.org/gitweb/?p=postgresql.git;a=commit;h=006b9dcad41956f180f9363648206fede8417592

Change History (5)

comment:1 by robe, 4 years ago

Description: modified (diff)
Summary: Can't compile against pg13Can't compile against pg13 no such file - utils/jsonapi.h

comment:2 by robe, 4 years ago

Owner: changed from pramsey to robe

comment:3 by Algunenano, 4 years ago

I updated Travis latest docker image and it shows the same error (https://travis-ci.org/Algunenano/postgis/jobs/643787692):

gcc -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Werror=vla -Wendif-labels -Wmissing-format-attribute -Wformat-security -fno-strict-aliasing -fwrapv -fexcess-precision=standard -Wno-format-truncation -Wno-stringop-truncation -g -ggdb -Og -g3 -fno-omit-frame-pointer -fPIC -I../liblwgeom -std=gnu99 -g -O2 -mtune=generic -fno-omit-frame-pointer -Werror -Wall -Wextra -Wformat -Werror=format-security -Wno-unused-parameter -Wno-implicit-fallthrough -Wno-unknown-warning-option -Wno-cast-function-type -fno-math-errno -fno-signed-zeros -I../libpgcommon -I../deps/wagyu -I../deps/uthash/include  -I/usr/local/include -I/usr/local/include  -I/usr/include/libxml2 -I/usr/local/include -I/usr/include/json-c  -DNDEBUG   -fPIC -DPIC -I/usr/local/include -I. -I./ -I/usr/local/pgsql/include/server -I/usr/local/pgsql/include/internal  -D_GNU_SOURCE   -c -o postgis_legacy.o postgis_legacy.c
lwgeom_out_geojson.c:20:10: fatal error: utils/jsonapi.h: No such file or directory
   20 | #include "utils/jsonapi.h"
      |          ^~~~~~~~~~~~~~~~~
compilation terminated.

It should be easy to fix. I'll give it a try.

comment:4 by Raúl Marín <git@…>, 4 years ago

Resolution: fixed
Status: newclosed

In 2a9e136/git:

PG13: Change include path for jsonapi.h

Closes #4632

comment:5 by Raúl Marín <git@…>, 4 years ago

In ffe43e3/git:

PG13: Change include path for jsonapi.h

References #4632 for 3.0

Note: See TracTickets for help on using tickets.