lwgeom_set_handlers changed signature

[strk]

r13617 (June 4 2015) changed the signature of lwgeom_set_handlers. This is a breaking change, not backward compatible, and should be reverted. The way to add handlers to the context should be by using another function instead.

[pramsey]

I thought I was allowed to do whatever I wanted to liblwgeom, that I wouldn't be bound to maintain a stable API, that was one of the points I was sold when I said "no way, no liblwgeom". All our internal calls to it use the new API, so… what's the problem?

[strk]

That sale was from 2.0. We're 2.2 now, slowly growing. Spatialite already uses liblwgeom (statically links to it). And QGIS is planning to use it too. Should we discourage these users ?

Personally I'd rather keep moving toward an independent library, even if slowly. The alternative, for those who invested in reusing it, would be to make it available as a fork, which could be worst than keeping it in postgis for some more time (I'm thinking of all the signatures that are only in the "internal" header).

I can do the work of maintaining the API if it's just a matter of time cost.

[Bborie Park]

@strk, I like spinning out to independent libraries (same with raster). But independent means drift from postgis.

[strk]

Fixed with r13646. For the record, another user here: ​https://lists.osgeo.org/pipermail/postgis-users/2015-March/040333.html

@dustymugs you mean you'd be in favour of moving liblwgeom to its own repository ? (but this discussion really belongs to the mailing list now)