Opened 4 years ago

Closed 3 years ago

Last modified 3 years ago

#3224 closed defect (fixed)

broken links to source code and history in add-ons user manuals

Reported by: veroandreo Owned by: martinl
Priority: normal Milestone: 7.2.1
Component: Addons Version: svn-releasebranch72
Keywords: add-ons, links, user manual Cc: grass-dev@…
CPU: x86-64 Platform: Linux

Description

Currently, the links to source code and history in Add-ons manuals are broken. If I run for example g.manual r.hants, both in 72 and trunk, the links are visible at the end of the manual page, but when I click on them I get the following error:

Trac Error

No node grass/trunk/home/veroandreo/tmp/grass7-veroandreo-27448/tmpsxrXTg/r.hants at revision 70081

Change History (27)

comment:1 Changed 4 years ago by neteler

In order to get the link to source code/history also into the Addon manual pages: backport to GRASS GIS 7.0.svn in r70192.

The desired links should show up the next time the addons are generated. Please check in a few day(s) and close the ticket if fixed.

... unrelated, sorry.

Last edited 4 years ago by neteler (previous) (diff)

comment:2 Changed 3 years ago by neteler

The same bug affects also the online Addon manual pages:

https://grass.osgeo.org/grass72/manuals/addons/

--> any addon --> SOURCE CODE -> Available at: source code (history)

comment:3 Changed 3 years ago by martinl

Cc: grass-dev@… added
Owner: changed from grass-dev@… to martinl
Status: newassigned

comment:4 Changed 3 years ago by martinl

In 70235:

broken links to source code and history in add-ons user manuals (see #3224)

comment:5 Changed 3 years ago by martinl

In 70237:

broken links to source code and history in add-ons user manuals (see #3224)

comment:6 Changed 3 years ago by martinl

In 70238:

broken links to source code and history in add-ons user manuals (see #3224)

(relb72: partial merge r70235 from trunk)

comment:7 Changed 3 years ago by martinl

The issue should be fixed, see eg. (1). Before closing ticket also WinGRASS binaries should be checked (next build).

(1) https://grass.osgeo.org/grass72/manuals/addons/g.proj.identify.html

comment:8 in reply to:  7 Changed 3 years ago by martinl

Replying to martinl:

The issue should be fixed, see eg. (1). Before closing ticket also WinGRASS binaries should be checked (next build).

(1) https://grass.osgeo.org/grass72/manuals/addons/g.proj.identify.html

I checked (1), still an issue

grep source docs/html/g.proj.identify.html 
<p>Available at: <a href="C:\msys64\usr\src\grass_addons\grass7\general\g.proj.identify">g.proj.identify source code</a> (<a href="C:\msys64\usr\src\grass_addons\grass7\general\g.proj.identify">history</a>)</p>

(1) https://wingrass.fsv.cvut.cz/grass72/x86_64/addons/grass-7.2.0/g.proj.identify.zip

comment:9 Changed 3 years ago by martinl

In 70263:

broken links to source code and history in add-ons user manuals (see #3224)

comment:10 Changed 3 years ago by martinl

Resolution: fixed
Status: assignedclosed

Seems to be fixed by r70263

wget https://wingrass.fsv.cvut.cz/grass72/x86_64/addons/grass-7.2.svn/g.proj.identify.zip
unzip g.proj.identify.zip
grep source docs/html/g.proj.identify.html
<p>Available at: <a href="https://trac.osgeo.org/grass/browser/grass-addons/grass7/general/g.proj.identify">g.proj.identify source code</a> (<a href="https://trac.osgeo.org/grass/log/grass-addons/grass7/general/g.proj.identify">history</a>)</p>

Closing. Feel free to reopen if needed. Please note that GRASS 7.2.0 WinGRASS AddOns will remain broken, the fix will be part of 7.2.1 release.

comment:11 Changed 3 years ago by veroandreo

Resolution: fixed
Status: closedreopened

Reopening this ticket since links to source code and history in r.modis.* and r.green.* modules (apparently those belonging to a group) are still broken.

This is the message I get in trac:

Trac Error No node grass-addons/grass7/raster/r.green.biomassfor.legal at revision 70410

comment:12 Changed 3 years ago by martinl

In 70514:

broken links to source code and history in add-ons user manuals (see #3224)

comment:13 in reply to:  11 ; Changed 3 years ago by martinl

Replying to Veronica Andreo:

Reopening this ticket since links to source code and history in r.modis.* and r.green.* modules (apparently those belonging to a group) are still broken.

This is the message I get in trac:

Trac Error No node grass-addons/grass7/raster/r.green.biomassfor.legal at revision 70410

Should be fixed in trunk (r70514). Testing welcome.

comment:14 in reply to:  13 ; Changed 3 years ago by veroandreo

Replying to martinl:

Replying to Veronica Andreo:

Reopening this ticket since links to source code and history in r.modis.* and r.green.* modules (apparently those belonging to a group) are still broken.

This is the message I get in trac:

Trac Error No node grass-addons/grass7/raster/r.green.biomassfor.legal at revision 70410

Should be fixed in trunk (r70514). Testing welcome.

I just recompiled to r70525M. I'm still getting the same error both when calling the manual through g.manual r.modis.import and going to the source code link there, and when going to the manual web page directly (https://grass.osgeo.org/grass72/manuals/addons/r.modis.import.html) and clicking on souce code link.

comment:15 in reply to:  14 ; Changed 3 years ago by martinl

Replying to Veronica Andreo:

I just recompiled to r70525M. I'm still getting the same error both when calling the manual

trunk?

through g.manual r.modis.import and going to the source code link there, and when going to the manual web page directly (https://grass.osgeo.org/grass72/manuals/addons/r.modis.import.html) and clicking on souce code link.

Online manuals are built against G72, I haven't backported yet.

Last edited 3 years ago by martinl (previous) (diff)

comment:16 in reply to:  15 ; Changed 3 years ago by veroandreo

Replying to martinl:

Replying to Veronica Andreo:

I just recompiled to r70525M. I'm still getting the same error both when calling the manual

trunk?

Yes, trunk. Sorry

through g.manual r.modis.import and going to the source code link there, and when going to the manual web page directly (https://grass.osgeo.org/grass72/manuals/addons/r.modis.import.html) and clicking on souce code link.

Online manuals are built against G72, I haven't backported yet.

Right, I forgot.

comment:17 in reply to:  16 ; Changed 3 years ago by martinl

Replying to Veronica Andreo:

I just recompiled to r70525M. I'm still getting the same error both when calling the manual

trunk?

Yes, trunk. Sorry

hm, tested again. Works? Are you sure that you have fresh version compiled? Anyone else who could test?

g.extension r.modis
g.manual r.modis.download

-> check source code link at the bottom of the manual

comment:18 in reply to:  17 Changed 3 years ago by martinl

Replying to martinl:

hm, tested again. Works? Are you sure that you have fresh version compiled? Anyone else who could test?

are you sure that you haven't installed r.modis in different way (running manually make from svn addons repo or so)? In this case you probably see different manual page than installed using G72:g.extension.

comment:19 Changed 3 years ago by martinl

In 70535:

broken links to source code and history in add-ons user manuals (see #3224)

(wingrass addons builds broken by r70514)

comment:20 Changed 3 years ago by martinl

I discovered that r70514 broked wingrass andons builds, hopefully fixed in r70535 (will check tomorrow)

comment:21 in reply to:  17 Changed 3 years ago by veroandreo

Replying to martinl:

Replying to Veronica Andreo:

I just recompiled to r70525M. I'm still getting the same error both when calling the manual

trunk?

Yes, trunk. Sorry

hm, tested again. Works? Are you sure that you have fresh version compiled? Anyone else who could test?

g.extension r.modis
g.manual r.modis.download

-> check source code link at the bottom of the manual

I had a fresh version compiled, but yeah, the problem might have been with my add-ons installation. Sorry for that. Anyway, I compiled again, now on trunk r70537M. It works (fedora 24 and fedora 25, windows I cannot tell). Thanks, Martin! :)

comment:22 Changed 3 years ago by martinl

In 70546:

broken links to source code and history in add-ons user manuals (see #3224)

(another attempt to fix wingrass addons builds)

comment:23 Changed 3 years ago by martinl

In 70605:

broken links to source code and history in add-ons user manuals (see #3224)

(merge r70546 from trunk)

comment:24 Changed 3 years ago by martinl

In 70660:

fix url source link on windows (see #3224)

comment:25 Changed 3 years ago by martinl

In 70673:

fix url source link on windows (see #3224)

(relbr72: merge r70660 from trunk)

comment:26 Changed 3 years ago by martinl

Resolution: fixed
Status: reopenedclosed

comment:27 Changed 3 years ago by hcho

In 70737:

mkhtml.py: Fix broken links for addon manuals when compiling without SOURCE_URL (Fix #3224)

Note: See TracTickets for help on using tickets.