m.nviz.image does not work on Windows

[annakrat]

Module m.nviz.image does not create valid image file on Windows. With tif format, it crashes and with ppm it creates a file only with header. So offscreen rendering doesn't seem to work. Has m.nviz.image ever worked on Windows?

[hamish]

Replying to annakrat:

Module m.nviz.image does not create valid image file on Windows. With tif format, it crashes and with ppm it creates a file only with header. So offscreen rendering doesn't seem to work.

was the wingrass version in question built with libtiff support?

see lib/ogsf/gsd_img_tif.c, nothing too complicated in there. gsd_img_ppm.c is even simpler. If header part is ok but writing the rest of the ppm image isn't, perhaps gsd_getimage() is returning bad values for xsize and ysize?

Has m.nviz.image ever worked on Windows?

I don't know if anyone ever tested that; does saving as tiff or ppm from the G6 tcl/tk NVIZ on wingrass work?

Hamish

[annakrat]

Replying to hamish:

Replying to annakrat:

Module m.nviz.image does not create valid image file on Windows. With tif format, it crashes and with ppm it creates a file only with header. So offscreen rendering doesn't seem to work.

was the wingrass version in question built with libtiff support?

see lib/ogsf/gsd_img_tif.c, nothing too complicated in there. gsd_img_ppm.c is even simpler. If header part is ok but writing the rest of the ppm image isn't, perhaps gsd_getimage() is returning bad values for xsize and ysize?

Has m.nviz.image ever worked on Windows?

I don't know if anyone ever tested that; does saving as tiff or ppm from the G6 tcl/tk NVIZ on wingrass work?

It worked I guess but I am talking here about off-screen rendering which is different than just exporting image with opened window with (wx)nviz.

[hamish]

Replying to annakrat:

Replying to hamish:

does saving as tiff or ppm from the G6 tcl/tk NVIZ on wingrass work?

It worked I guess but I am talking here about off-screen rendering which is different than just exporting image with opened window with (wx)nviz.

I asked because G6's tcl/tk NVIZ and m.nviz.image both use libogsf's GS_write_ppm() which calls gsd_getimage() to get the image size. I was trying to narrow down if the gsd_getimage() function was where the problem lies.

Hamish

[martinl]

Still an issue?

[annakrat]

Replying to martinl:

Still an issue?

Yes.

[martinl]

Milestone renamed

[wenzeslaus]

This now seems to be an issue on Linux as well. On Ubuntu 16.04:

> m.nviz.image elevation_map=elevation output=test format=ppm size=640,480
X Error of failed request:  BadValue (integer parameter out of range for operation)
  Major opcode of failed request:  154 (GLX)
  Minor opcode of failed request:  3 (X_GLXCreateContext)
  Value in failed request:  0x0
  Serial number of failed request:  24
  Current serial number in output stream:  29

Changing platform to all. New ticket more appropriate? New implementation seems to be necessary.

[neteler]

Ticket retargeted after milestone closed

[hcho]

This specific issue on Linux is fixed by r72939.

Replying to wenzeslaus:

This now seems to be an issue on Linux as well. On Ubuntu 16.04:

> m.nviz.image elevation_map=elevation output=test format=ppm size=640,480
X Error of failed request:  BadValue (integer parameter out of range for operation)
  Major opcode of failed request:  154 (GLX)
  Minor opcode of failed request:  3 (X_GLXCreateContext)
  Value in failed request:  0x0
  Serial number of failed request:  24
  Current serial number in output stream:  29

Changing platform to all. New ticket more appropriate? New implementation seems to be necessary.

[hcho]

Maybe, these patches will help.

• ​https://trac.osgeo.org/grass/attachment/ticket/3600/lib-ogsf-gsd_prim.c.diff
• ​https://trac.osgeo.org/grass/attachment/ticket/3600/lib-nviz-render.c.2.diff

[hcho]

In 72997:

nviz: offscreen rendering for Windows (Fix #2114)

[hcho]

Please test r72997 on Windows. Works for me.

[hellik]

Replying to hcho:

Please test r72997 on Windows. Works for me.

see #3600#comment:77

seems to work now

[hcho]

Replying to hellik:

Replying to hcho:

Please test r72997 on Windows. Works for me.

see #3600#comment:77

seems to work now

Great! I think we can close this ticket. Hmm.. the platform is All? Works on Linux and Windows.

[hcho]

In 73006:

nviz, ogsf: Use framebuffer objects for off-screen GL rendering; Use Core OpenGL (CGL) for the MacOS instead of deprecated 32-bit only AGL (Fix #3600, #2114, #3606)

[martinl]

Milestone set to 7.4.2. Re-opening since backport has not been done.

[hcho]

Backported to 7.2 & 7.4.