#292 closed task (fixed)
MeasureTool - complete recreation using GeoExt.ux.Measure
Reported by: | adube | Owned by: | |
---|---|---|---|
Priority: | major | Milestone: | 1.2.0 |
Component: | widgets | Version: | trunk |
Keywords: | bis-1.2.0, measure, measuretool, deprecate, ux | Cc: |
Description
MeasureTool status
It was mentioned in #291 that the MeasureTool widget completely overrides (replaces) native OpenLayers.Control.Measure methods and properties without extending them, which is a bad thing. The way that widget was made is wrong and should be re-made.
Solution : GeoExt.ux.Measure
An other solution could be to integrate the !GeoExt.ux.Measure ux widget, which is already an official GeoExt ux and deprecate the MeasureTool.
If that new widget misses features the old one did, then the changes could be contributed to the GeoExt community.
Any thoughts ?
Change History (8)
comment:1 by , 13 years ago
Milestone: | → 1.0.0 |
---|
comment:2 by , 13 years ago
Summary: | Add GeoExt.ux.Measure, deprecate MeasureTool → MeasureTool - complete recreation using GeoExt.ux.Measure |
---|
comment:3 by , 13 years ago
comment:4 by , 13 years ago
Milestone: | 1.0.0 → 1.2.0 |
---|
Since it would require to much work and time is missing, this task will be handled in the next release.
comment:5 by , 13 years ago
Resolution: | → fixed |
---|---|
Status: | new → closed |
Version: | → trunk |
MeasureTool widget completely remade in r1229.
Technical details
- we don't use GeoExt.ux.Measure
- instead, we borrowed the source of the gxp.plugins.Measure from GXP library (BSD License revision)
- widget is now one menu button that support both measure methods : "length" and "area and perimeter"
- i18n (fr) now in javascript (.mo and .po files removed)
- documentation and sample adjusted accordingly
- all OpenLayers styling related options were removed
Migration
- because the widget now supports both measure methods (lengh and area), you no longer need to define 2 widgets. Use only one
- "tohectare" option now "hectare"
- all OpenLayers styling related options were removed, so you no longer need them
comment:6 by , 13 years ago
r1230, featuring :
- old class names used by the toolbar for the controls were removed.
Migration
- css class name, instead of "measuretoolArea", use "gp-measuretool-icon-measure-area"
- css class name, instead of "measuretoolLength", use "gp-measuretool-icon-measure-length"
comment:8 by , 13 years ago
Keywords: | bis-1.2.0 added |
---|
Instead of deprecating the MeasureTool and create a new geoextux_measure one, we should simply reuse the widget name, clear all widget code and start from scratch using the GeoExt.ux.Measure source.