Opened 9 years ago

Closed 9 years ago

Last modified 9 years ago

#5995 closed defect (fixed)

Various typo fixes

Reported by: Bas Couwenberg Owned by: warmerdam
Priority: normal Milestone: 2.0.0
Component: default Version: svn-trunk
Severity: normal Keywords:
Cc: sebastic@…

Description (last modified by Bas Couwenberg)

This is a follow-up for the previous issue (#5756).

Refreshing the typo patches included in the Debian package left many changes unfixed for 2.0.0RC1.

The attached patches fix the typos.

If portions of these patches are not acceptable for inclusion (e.g. typos in variables or functions), we should leave those changes out of the Debian package too (and override the QA issue for the typo).

I'd like to have only distribution specific patches left in the Debian package for the final 2.0.0 release.

Attachments (12)

paramters-typo (721 bytes ) - added by Bas Couwenberg 9 years ago.
inconsistant-typo (9.1 KB ) - added by Bas Couwenberg 9 years ago.
consistant-typo (11.0 KB ) - added by Bas Couwenberg 9 years ago.
explicitely-typo (23.0 KB ) - added by Bas Couwenberg 9 years ago.
ressource-typo (656 bytes ) - added by Bas Couwenberg 9 years ago.
transfered-typo (1.9 KB ) - added by Bas Couwenberg 9 years ago.
initalize-typo (1.3 KB ) - added by Bas Couwenberg 9 years ago.
usefull-typo (10.9 KB ) - added by Bas Couwenberg 9 years ago.
supress-typo (4.2 KB ) - added by Bas Couwenberg 9 years ago.
recommanded-typo (515 bytes ) - added by Bas Couwenberg 9 years ago.
paramater-typo.diff (2.1 KB ) - added by Bas Couwenberg 9 years ago.
allows-to-typo.diff (12.2 KB ) - added by Bas Couwenberg 9 years ago.

Download all attachments as: .zip

Change History (20)

by Bas Couwenberg, 9 years ago

Attachment: paramters-typo added

by Bas Couwenberg, 9 years ago

Attachment: inconsistant-typo added

by Bas Couwenberg, 9 years ago

Attachment: consistant-typo added

by Bas Couwenberg, 9 years ago

Attachment: explicitely-typo added

by Bas Couwenberg, 9 years ago

Attachment: ressource-typo added

by Bas Couwenberg, 9 years ago

Attachment: transfered-typo added

by Bas Couwenberg, 9 years ago

Attachment: initalize-typo added

by Bas Couwenberg, 9 years ago

Attachment: usefull-typo added

by Bas Couwenberg, 9 years ago

Attachment: supress-typo added

by Bas Couwenberg, 9 years ago

Attachment: recommanded-typo added

comment:1 by Bas Couwenberg, 9 years ago

Description: modified (diff)

comment:2 by Even Rouault, 9 years ago

All patches applied in trunk r29329, branches/2.0 r29330 "Fix various English typos in doc and code (patch by Bas Couwenger + autotest related changes by myself, #5995)"

This will likely go in 2.0.1 since 2.0.0RC1 is being voted to be approved as final.

I'm wondering if there would be a way to catch those typos in a continuous way during the dev process. For example if it could be a step in the build process run by Travis (so something runnable on Ubuntu 12.04)

in reply to:  2 comment:3 by Bas Couwenberg, 9 years ago

Replying to rouault:

All patches applied in trunk r29329, branches/2.0 r29330 "Fix various English typos in doc and code (patch by Bas Couwenger + autotest related changes by myself, #5995)"

Thanks for applying the changes, I've marked the patches in the Debian package accordingly.

This will likely go in 2.0.1 since 2.0.0RC1 is being voted to be approved as final.

I saw the vote gdal-dev@, that triggered me to update the Debian packages with the pre-releases. We're stilling trying to migrate from 1.10.1 to 1.11.2 in Debian, that's why I didn't get around to working on 2.0.0 earlier. We'll likely still migrate to 1.11.2 in Debian before moving to 2.0.0, but if no changes for GDAL 2.0 are required in the reverse dependencies we may still skip 1.11.2 in Debian (this seems highly unlikely though).

I'm wondering if there would be a way to catch those typos in a continuous way during the dev process. For example if it could be a step in the build process run by Travis (so something runnable on Ubuntu 12.04)

Ubuntu precise is really showing its age with little less than 2 years support left. Travis should really upgrade to a newer LTS release to have recent package versions available.

While lintian is not easy to use outside of Debian packaging, the codespell tool could be integrated in the testsuite to achieve a similar result. Ubuntu includes the package since trusty.

by Bas Couwenberg, 9 years ago

Attachment: paramater-typo.diff added

by Bas Couwenberg, 9 years ago

Attachment: allows-to-typo.diff added

comment:4 by Bas Couwenberg, 9 years ago

I've added two more patches to fix some more issues found for 2.0.0RC1, that were not covered by the earlier patches.

comment:5 by Even Rouault, 9 years ago

Resolution: fixed
Status: newclosed

trunk r29335, branches/2.0 r29336 "More typo fixes (allows-to-typo.diff, paramater-typo.diff) (patch by Bas Couwenger, #5995)"

Actually because of #5999 there will be a RC2 so all the above will be in final 2.0.0

in reply to:  2 comment:6 by Bas Couwenberg, 9 years ago

Replying to rouault:

All patches applied in trunk r29329, branches/2.0 r29330 "Fix various English typos in doc and code (patch by Bas Couwenger + autotest related changes by myself, #5995)"

The 'initalize-typo' patch is not applied in the above changesets.

Shall I bundle typo fixes into in single patch next time, or just number the patches in the series?

comment:7 by Even Rouault, 9 years ago

trunk r29350, branches/2.0 r29351 (post RC2) "Apply initalize-typo (#5995)"

Yes, a single patch would be less prone to forgetting a patch.

comment:8 by Even Rouault, 9 years ago

Milestone: 2.02.0.0

Milestone renamed

Note: See TracTickets for help on using tickets.