Ticket #1162 (closed defect: fixed)
chuck old junk about older versions of PostgreSQL
|Reported by:||robe||Owned by:||pramsey|
Given all the problems I am having, I have been forced to look at some of the code we have.
We've got ifdefs that are just dead weight.
Case in point: libpgcommon\pgsql_compat.h
We don't support anything lower than 8.4 so none of these conditions really makes sense to have. The file should either be blanked out or be gone.
Same goes for that PG_MODULE_MAGIC ifdef stuff. All versions we have now require PG_MODULE_MAGIC so why do we bother with ifdef.
Same goes for postgis/lwgeom_accum.c
We've got code that has:
#if POSTGIS_PGSQL_VERSION < 84 result = makeMdArrayResult(state, 1, dims, lbs, mctx); #else result = makeMdArrayResult(state, 1, dims, lbs, mctx, false); #endif
We don't support lower than 8.4 -- this should be just:
result = makeMdArrayResult(state, 1, dims, lbs, mctx, false);
I'd be willing to cleanup some of this if only I could compile again.