Ticket #1163 (closed defect: fixed)

Opened 22 months ago

Last modified 22 months ago

move SQL-exposed functions out of libpgcommon

Reported by: bnordgren Owned by: pramsey
Priority: medium Milestone: PostGIS 2.0.0
Component: postgis Version: trunk
Keywords: Cc:

Description

In general, it seems that anything having a need to be directly accessible to SQL should not be in libpgcommon, but rather in postgis or raster. Putting it in libpgcommon seems to be causing an issue for Windows.

Attached patch cleans out libpgcommon. Apply against r7757

Attachments

transform_fix.patch Download (12.3 KB) - added by bnordgren 22 months ago.

Change History

Changed 22 months ago by bnordgren

Changed 22 months ago by strk

In file included from /usr/include/postgresql/8.4/server/postgres.h:47,
                 from ../libpgcommon/lwgeom_transform.h:13,
                 from lwgeom_transform.c:14:
/usr/include/postgresql/8.4/server/c.h:235: error: redefinition of typedef ‘int32’
../liblwgeom/liblwgeom.h:147: note: previous declaration of ‘int32’ was here
/usr/include/postgresql/8.4/server/c.h:247: error: redefinition of typedef ‘uint32’
../liblwgeom/liblwgeom.h:146: note: previous declaration of ‘uint32’ was here
make[1]: *** [lwgeom_transform.o] Error 1
make[1]: Leaving directory `/home/src/postgis/postgis/postgis'
make: *** [all] Error 1

Changed 22 months ago by strk

  • status changed from new to closed
  • version changed from 1.5.X to trunk
  • resolution set to fixed

I had to swap includes in lwgeom_transform.h. Committed in r7758

Note: See TracTickets for help on using tickets.