Opened 14 years ago

Closed 14 years ago

#1163 closed defect (fixed)

move SQL-exposed functions out of libpgcommon

Reported by: bnordgren Owned by: pramsey
Priority: medium Milestone: PostGIS 2.0.0
Component: postgis Version: master
Keywords: Cc:

Description

In general, it seems that anything having a need to be directly accessible to SQL should not be in libpgcommon, but rather in postgis or raster. Putting it in libpgcommon seems to be causing an issue for Windows.

Attached patch cleans out libpgcommon. Apply against r7757

Change History (3)

by bnordgren, 14 years ago

Attachment: transform_fix.patch​ added

comment:1 by strk, 14 years ago 

In file included from /usr/include/postgresql/8.4/server/postgres.h:47,
                 from ../libpgcommon/lwgeom_transform.h:13,
                 from lwgeom_transform.c:14:
/usr/include/postgresql/8.4/server/c.h:235: error: redefinition of typedef ‘int32’
../liblwgeom/liblwgeom.h:147: note: previous declaration of ‘int32’ was here
/usr/include/postgresql/8.4/server/c.h:247: error: redefinition of typedef ‘uint32’
../liblwgeom/liblwgeom.h:146: note: previous declaration of ‘uint32’ was here
make[1]: *** [lwgeom_transform.o] Error 1
make[1]: Leaving directory `/home/src/postgis/postgis/postgis'
make: *** [all] Error 1

comment:2 by strk, 14 years ago

Resolution: → fixed
Status: new → closed
Version: 1.5.X → trunk

I had to swap includes in lwgeom_transform.h. Committed in r7758

Note: See TracTickets for help on using tickets.