Opened 17 years ago

Last modified 13 years ago

#1988 assigned enhancement

zoomRectangle pixel input is confusing

Reported by: sdlime Owned by: sdlime
Priority: high Milestone: 6.0 release
Component: MapScript-SWIG Version: 5.0
Severity: minor Keywords:
Cc:

Description (last modified by dmorissette)

Folks: The pixel input is confusing for zoomRectangle. A rectangle is minx, miny, maxx, maxy and the code should take care of dealing with orientation issues (e.g. images have UL origin, maps LL origin) as opposed to the user. It's confusing, at least to me, to specify a rectangle with maxy <= miny. See bugs #1982 and #1817 for instances where this has tripped us up in the past.

With 5.0 I think we should support a proper rect as input, and allow flipped y coordinates for backwards compatability.

Steve

Change History (8)

comment:1 by sdlime, 17 years ago

Cc: hobu@… unicoletti@… mapserver-bugs@… dmorissette@… added

comment:2 by szekerest, 17 years ago

Cc: szekeres.tamas@… added

comment:3 by sdlime, 17 years ago

Severity: normal → enhancement

comment:4 by dmorissette, 17 years ago

blocked: → 1817, 1982
Milestone: → 5.0 release 
If I understand correctly, you propose that we modify zoomRectangle() in both
PHP and SWIG MapScript to swap the coordinates of the rectangle (in pixels)
automatically if necessary instead of expecting an input rect where miny > maxy.

If that's what you propose then I agree.

comment:5 by sdlime, 17 years ago 

Yes, that is what I was proposing.

Steve

comment:6 by sdlime, 17 years ago

Description: modified (diff)
Milestone: 5.0 release → 5.2 release
Status: new → assigned

Will wait to clean up in 5.2.

Steve

comment:7 by sdlime, 16 years ago

Milestone: 5.2 release → 5.4 release

Actually will clean up in 5.4 since nobody is complaining.

Steve

comment:8 by dmorissette, 13 years ago

Description: modified (diff)
Milestone: 5.6 release → 6.0 release

Moving to 6.0. Do we still want to do this?

Note: See TracTickets for help on using tickets.