#1817 closed defect (fixed)
zoomRectangle's behavior reverted
Reported by: | hobu | Owned by: | sdlime |
---|---|---|---|
Priority: | high | Milestone: | |
Component: | MapScript | Version: | unspecified |
Severity: | normal | Keywords: | |
Cc: |
Description
Umberto, I have reverted the change that you made to rect.i on May 30th regarding the swapping of miny and maxy. For images, miny and maxy are swapped pervasively throughout the code base because the origin for images is the top left corner, not the bottom right. The changes as you made them broke the Python test suite and potentially broke a bunch of code that's out there. We need to have a bug ID to watch changes like this, and please run the test suite by forcing a build on http://mapserver.builds.hobu.net if you want to see the result of commited changes. Thanks Howard
Change History (4)
comment:2 by , 18 years ago
I only changed mapzoom.i, did not touch rect.i. Now that I understand the deal with the 5th argument in the rectObj constructor I could get zoom to work with the original implementation. Sorry for the breakage. Should I add a line to HISTORY.txt?
comment:3 by , 18 years ago
Resolution: | → fixed |
---|---|
Status: | new → closed |
I had added a note to HISTORY.TXT, but mistakenly stated that it was rect.i being modified rather than mapzoom.i. Update the note in HISTORY.TXT as you see fit. I had started modifying everything to have the origin like you had set it in mapzoom.i until I realized that I was all of a sudden changing *a lot* of code that had worked just fine for a long time ;)
comment:4 by , 17 years ago
dependson: | → 1988 |
---|
Note:
See TracTickets
for help on using tickets.