Opened 15 years ago

Closed 15 years ago

#1162 closed defect (fixed)

MgGwsFeatureReader does not work with left-out joins

Reported by: Aleck Owned by: Aleck
Priority: low Milestone: 2.2
Component: General Version: 2.1.0
Severity: trivial Keywords:
Cc: External ID:

Description

When GWS query engine is involved in querying features, an MgServerGwsFeatureReader will be created for reading features.

In MgServerGwsFeatureReader::ReadNext() method, it'll get a right-side feature iterator for a left side feature using the following code:

retVal = secondaryIter->ReadNext(); If (retval) {

return the right-side feature ...

} else {

m_bAdvancePrimaryIterator = true;

}

Therefore, if there is no corresponding right-side feature, it'll skip the left side feature, which is wrong for left outer joins.

The solution is to check if it is a left outer join. If so, the left-side feature still need to be returned with the right side feature property value set to NULL

Attachments (1)

1.patch (12.0 KB ) - added by Aleck 15 years ago.
patch

Download all attachments as: .zip

Change History (3)

by Aleck, 15 years ago

Attachment: 1.patch added

patch

comment:1 by Aleck, 15 years ago

Milestone: 2.2
Version: 2.0.22.1.0

comment:2 by brucedechant, 15 years ago

Resolution: fixed
Status: newclosed

Fixed. See submission r4367

Note: See TracTickets for help on using tickets.