Opened 14 years ago

Closed 14 years ago

Last modified 14 years ago

#1161 closed defect (fixed)

Safari: Ajax activates URL by CTRL + CLICK but tooltips shows SHIFT+CLICK

Reported by: liuar Owned by:
Priority: low Milestone: 2.2
Component: General Version: 2.0.2
Severity: minor Keywords:
Cc: tomfukushima, chrisclaydon, pagmeba External ID: 1282217

Description

  1. Preview a weblayout with actived URL for features in a layer using Safari.
  2. Hover on one object.
  3. The tooltip displayed as "SHIFT+ CLICK" to invoke the URL

Shift + click is used for multi-selection actually, ctrl + click can invoke the URL like other browsers.

Attachments (1)

Patch1161.patch (3.2 KB ) - added by liuar 14 years ago.

Download all attachments as: .zip

Change History (12)

comment:1 by liuar, 14 years ago

External ID: 1282217

Since the behavior for safari is not different to other browsers, we can just curtail the "prerogative" from Safari.

comment:2 by tomfukushima, 14 years ago

The code would need to distinguish Safari on Window and Safari on Mac.

As pointed out by Mans on the mapguide-internals mailing list: On Apple computers ctrl+click is used for right click. That is the reason why it was set up different for Safari. I think this change was made before Safari became available for Windows.

comment:3 by liuar, 14 years ago

Cc: tomfukushima added; jenny.he@… removed

Thanks for your reply Tom. Mans is rigt, ctrl+click is used for right click. What should be distinguished is OS not browser.(FF could also be installed on Mac)

However, current design still have a problem. we can not use Shift+click(as designed) to invoke URL, beecause Shift+click is used for mutiple selection in MapGuide. Can we set it to others modifier keys?

comment:4 by tomfukushima, 14 years ago

Cc: chrisclaydon pagmeba added

Can we use the command key? Paul, do you know if it would be acceptable to use the Mac command key + click to open a URL in the MG basic viewer on the Mac?

comment:5 by pagameba, 14 years ago

I think that would work fine. I'm not sure what the right event codes are to trap command + click but I'm sure its possible to figure out. I tried 'command-click' in all my browsers and it does nothing special. In relation to usability, mac users use the command key in the same way that windows users use the control key (i.e. command-c is copy instead of ctrl-c)

by liuar, 14 years ago

Attachment: Patch1161.patch added

comment:6 by liuar, 14 years ago

Thanks for your suggestions. I've uploaded a new patch and tested on Safari, FF and Chrome based on MacOS. Please review it. Thanks.

comment:7 by chrisclaydon, 14 years ago

The patch looks good. If you ctrl-click on a Mac, does the MapGuide context menu pop up?

comment:8 by liuar, 14 years ago

Thank you for this review. Ctrl + Click can open the context menu on Mac.

comment:9 by liuar, 14 years ago

Resolution: fixed
Status: newclosed

comment:10 by tomfukushima, 14 years ago

Actually, it's fixed by r4443.

comment:11 by brucedechant, 14 years ago

Milestone: 2.2
Note: See TracTickets for help on using tickets.