Opened 15 years ago

Closed 13 years ago

#1136 closed defect (fixed)

PATCH: Layer checkbox is not accessed properly in show function: /www/fusion/layers/Layers.js

Reported by: poulet1212 Owned by:
Priority: medium Milestone:
Component: Fusion Version: 2.1.0
Severity: minor Keywords:
Cc: External ID:

Description

In the file: /www/fusion/layers/Layers.js

At line 322, the function:

show: function(noDraw) {

if (this.visible) {

return;

} this.oMap.showGroup(this, noDraw ? true : false); this.visible = true; if (this.legend && this.legend.checkBox) {

this.legend.checkBox.checked = true;

}

},

Should be changed like this to access correctly the legend's checkbox object of the group:

show: function(noDraw) {

if (this.visible) {

return;

} this.oMap.showGroup(this, noDraw ? true : false); this.set('visible', true); if (this.legend && this.legend.treeItem && this.legend.treeItem.checkBox) {

this.legend.treeItem.checkBox.checked = true;

}

},

The same for a layer at line: 469:

show: function(noDraw) {

if (this.visible) {

return;

} this.set('visible', true); this.oMap.showLayer(this, noDraw ? true : false); if (this.legend && this.legend.checkBox) {

this.legend.checkBox.checked = true;

}

},

should be changed like this:

show: function(noDraw) {

if (this.visible) {

return;

} this.set('visible', true); this.oMap.showLayer(this, noDraw ? true : false); if (this.legend && this.legend.treeItem && this.legend.treeItem.checkBox) {

this.legend.treeItem.checkBox.checked = true;

}

},

Change History (3)

comment:1 by tomfukushima, 15 years ago

Note, that this file is in the Fusion SVN. Can you create a Fusion ticket, and add a note in this ticket that references the Fusion ticket?

comment:2 by poulet1212, 15 years ago

New ticket opened in Fusion trac:

http://trac.osgeo.org/fusion/ticket/313

comment:3 by jng, 13 years ago

Resolution: fixed
Status: newclosed

Fusion trac indicates the ticket has been fixed

Note: See TracTickets for help on using tickets.