Ticket #313 (closed defect: fixed)

Opened 4 years ago

Last modified 3 years ago

PATCH: Layer checkbox is not accessed properly in show function: /www/fusion/layers/Layers.js

Reported by: poulet1212 Owned by: madair
Priority: P2 Milestone: 2.2
Component: Widgets Version: 1.1.1
Severity: Major Keywords:
Cc: External ID:
state: New Browser: All
Operating System: All

Description

In the file: /www/fusion/layers/Layers.js (version from Mapguide 2.1 beta)

At line 322, the function:

show: function(noDraw) {

if (this.visible) {

return;

} this.oMap.showGroup(this, noDraw ? true : false); this.visible = true; if (this.legend && this.legend.checkBox) {

this.legend.checkBox.checked = true;

}

},

Should be changed like this to access correctly the legend's checkbox object of the group:

show: function(noDraw) {

if (this.visible) {

return;

} this.oMap.showGroup(this, noDraw ? true : false); this.set('visible', true); if (this.legend && this.legend.treeItem && this.legend.treeItem.checkBox) {

this.legend.treeItem.checkBox.checked = true;

}

},

The same for a layer at line: 469:

show: function(noDraw) {

if (this.visible) {

return;

} this.set('visible', true); this.oMap.showLayer(this, noDraw ? true : false); if (this.legend && this.legend.checkBox) {

this.legend.checkBox.checked = true;

}

},

should be changed like this:

show: function(noDraw) {

if (this.visible) {

return;

} this.set('visible', true); this.oMap.showLayer(this, noDraw ? true : false); if (this.legend && this.legend.treeItem && this.legend.treeItem.checkBox) {

this.legend.treeItem.checkBox.checked = true;

}

},

Change History

Changed 3 years ago by madair

  • milestone changed from Future to 2.1

Changed 3 years ago by madair

  • milestone changed from 2.1 to 2.2

Changed 3 years ago by madair

  • status changed from new to closed
  • resolution set to fixed

fixed in [2202]. Thanks for the bug fix!

Note: See TracTickets for help on using tickets.