new symbology line decoration with wrong orientation

[strk]

I'm showing 2 lines with new symbology and line decoration. Both lines are horizontal 2 points segments. The one above goes right-to-left. The one below goes left-to-right.

I would expect the line decoration (kind of an arrow head) to go in the direction of the line, but this is not happening for the right-to-left one.

Here's a snapshot: ​http://strk.keybit.net/tmp/qgis_new_symbology_line_decoration.png

For reference, WKT of the two lines: 10: LINESTRING(35 14,21 14) 13: LINESTRING(21 6,35 6)

This is qgis r15056

[strk]

Further debugging shows that the problem has to do with the final segment being _exactly_ horizontal. I suspect there's en equal problem with perfectly vertical lines, as per this other snapshot: ​http://strk.keybit.net/tmp/ArrowHeadHell.png

[strk]

Found and fixed. Attached format-patch (good to apply with git-am). Problem was for both vertical and horizontal lines. Fixed the vertical case (int vs. float) and the horizontal case (just missing).

[jef]

The attached patch is shorter, but I didn't test it - strk could you try it with your testcase, please?

[strk]

jef suggested this much simplified version: ​http://paste.debian.net/105578/ I've tested it and works fine.

[jef]

Replying to strk:

jef suggested this much simplified version: ​http://paste.debian.net/105578/ I've tested it and works fine.

Thanks. Applied in r15076.