Opened 13 years ago
Closed 13 years ago
#3259 closed patch (fixed)
Delimited text enhancement - use WKT column
| Reported by: | ccrook | Owned by: | gsherman |
|---|---|---|---|
| Priority: | major: does not work as expected | Milestone: | Version 1.7.0 |
| Component: | Data Provider | Version: | Trunk |
| Keywords: | delimited text provider plugin | Cc: | |
| Must Fix for Release: | No | Platform: | All |
| Platform Version: | Awaiting user input: | no |
Description
This is a proposal for an enhancement to the delimited text plugin to allow it to use a geometry column formatted as well known text, as an alternative to using x and y columns to define point features.
The attached patch implements this option.
The main limitation in this implementation is that all the geometries must be of the same well known text type.
Attachments (4)
Change History (12)
comment:1 by , 13 years ago
| Type: | enhancement → patch |
|---|
comment:2 by , 13 years ago
by , 13 years ago
| Attachment: | delimited_text_enhancement.patch added |
|---|
Patch file to implement delimited text provider enhancement
comment:3 by , 13 years ago
New version of patch added .. this version handles .. Z, .. M, and .. ZM type geometries by removing the Z, M, ZM, and removing extra coordinates from the WKT string before passing it to the QgsGeometry factory function.
comment:4 by , 13 years ago
| Owner: | changed from to |
|---|
Can you provide a couple of small test files with WKT coordinates?
by , 13 years ago
| Attachment: | gns_linestring.wkt added |
|---|
Example delimited text with wkt linestring elements
by , 13 years ago
| Attachment: | gns_poly.wkt added |
|---|
Example delimited text with wkt polygon elements (POLYGON Z)
follow-up: 6 comment:5 by , 13 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
Patch added in r14781
Help file and dialog modified to reflect addition of WKT capability.
Thanks for the patch!
comment:6 by , 13 years ago
comment:7 by , 13 years ago
| Resolution: | fixed |
|---|---|
| Status: | closed → reopened |
Discovered I introduced a bug in the selection of non-point objects (ie wkt objects). Currently selection testing is based on bound box of object only. Needs to include testing actual geometry of object.
Attached patch fixes this
by , 13 years ago
| Attachment: | delimited_text_enhancement_fix.patch added |
|---|
Patch to fix wkt object selection bug
I've found that this doesn't work when the WKT contains Z, M, or ZM types (eg LINESTRING Z(...). I'll provide a revised patch which handles this soon...