Opened 18 years ago

Closed 18 years ago

Last modified 15 years ago

#32 closed defect (fixed)

Save File As dialog boxes display "Open" button rather than "Save"

Reported by: tbaggett Owned by: timlinux
Priority: minor: annoyance Milestone:
Component: GUI Version: Trunk
Keywords: Cc:
Must Fix for Release: No Platform: Fedora
Platform Version: Core 3 Awaiting user input: no

Description (last modified by gsherman)

Save As Dialog Boxes Incorrectly Display "Open" Button

The following dialog boxes should show a "Save" button rather than an "Open" button.

  • File->Save Project As...
  • File->Save as Image...

This is observed with trunk r5105, built with Qt 4.1.1

Attachments (1)

patch.txt (2.0 KB ) - added by tbaggett 18 years ago.

Download all attachments as: .zip

Change History (8)

comment:1 by gsherman, 18 years ago

Description: modified (diff)

by tbaggett, 18 years ago

Attachment: patch.txt added

comment:2 by tbaggett, 18 years ago

Owner: changed from tbaggett to timlinux

I have attached a patch to qgisapp.cpp which I believe fixes this issue for both "save project as" and "save as image" dialog boxes, in addition to two another minor fixes.

  • The dialog box is configured to open a file by default. By setting the accept mode to AcceptSave, the "Open" button is now changed to "Save".
  • The dialog box is now configured to confirm if the user has selected an existing file to be overwritten. The code that previously performed this check and displayed a warning in fileSaveAs() was deleted in favor of the Qt confirmation. There was no corresponding check being performed in saveMapAsImage() as far as I could find.
  • The fileSaveAs() dialog box title is changed to match the existing title in the saveMapAsImage() dialog box.

A potential issue I see is that when the user is prompted to confirm overwriting an existing file, the titles are too long and are truncated in the confirmation dialog box.

comment:3 by gsherman, 18 years ago

Description: modified (diff)

comment:4 by gsherman, 18 years ago

Milestone: Version 0.8 Release

comment:5 by timlinux, 18 years ago

Resolution: fixed
Status: newclosed

Applied patch in revisiont r5107

Note that the File->save dialog option still shows 'open' instead of 'save'.

Many thanks for this patch!

comment:6 by anonymous, 17 years ago

Awaiting user input: unset
Must Fix for Release: No

comment:7 by (none), 15 years ago

Milestone: Version 0.8

Milestone Version 0.8 deleted

Note: See TracTickets for help on using tickets.