Opened 18 years ago

Closed 18 years ago

Last modified 15 years ago

#316 closed patch (fixed)

Added some tr (i18n support)

Reported by: lubaby Owned by: g_j_m
Priority: minor: annoyance Milestone:
Component: Internationalisation Version: Trunk
Keywords: Cc:
Must Fix for Release: No Platform: All
Platform Version: Awaiting user input: no

Description

Added some tr() for user visible text

Attachments (1)

added_tr.diff (30.7 KB ) - added by lubaby 18 years ago.

Download all attachments as: .zip

Change History (5)

by lubaby, 18 years ago

Attachment: added_tr.diff added

comment:1 by anonymous, 18 years ago

Owner: changed from gsherman to g_j_m

Thanks for the patch. I've applied, tested and committed most of them in SVN r5886 (but see below).

In qgsdelimitedtextprovider.cpp you replaced the line

QString filter = QString("Shapefiles (*.shp)");

with

QString filter = QString(tr("Shapefiles (*.shp)"));

I'm not familiar with how file suffixes change with languages, but is it correct to translate the *.shp too, given that this is used to select which files are visible in the dialog box?

I also changed the patch for the qgslabelattributes.cpp file as it was missing the tr() function.

comment:2 by lubaby, 18 years ago

Hi,

g_j_m wrote:

"I'm not familiar with how file suffixes change with languages, but is it correct to translate the *.shp too, given that this is used to select which files are visible in the dialog box? "

Of course suffixes don't change with language but there is also some additional text which could be useful to translate. Maybe in future if only one open dialog box would be used for all layer types (grass, raster, vector) it could be this text more verbose (e.g. "Vector ESRI shapefile (*.shp)") so the string "Vector" should be translated. Probably it it only theoretical argument for now but in general the "File filters" used to be translatable in the most of KDE applications (Koffice, Kpdf,...).

comment:3 by g_j_m, 18 years ago

Resolution: fixed
Status: newclosed

Did the *.shp tr() addition in svn r5892.

comment:4 by (none), 15 years ago

Milestone: Version 0.8

Milestone Version 0.8 deleted

Note: See TracTickets for help on using tickets.