Selection tool is not selecting a complex object

[gislab]

Try selecting a big polygon in a attached shapefile with the first selection tool. Big polygon cannot be selected, while smaller ones are selected alright.

Rings and self-intersection error are present in the big polygon, not sure if this is related though.

[jpalmer]

Yip there is a bug in the single select tool. The tool made the assumption that feature ids are always >0, when in fact a feature id can be 0 and in the case of editing can be negative integer values. The attached patch fixes the issue.

[gislab]

can somebody review and apply? current behavior makes selection tool unusable in many circumstances

[jef]

applied in r14259. Thanks again Jeremy.

[dr]

Select features by rectangle, by polygon, by radius and by freehand doesn't work on this polygon.

[jpalmer]

I can get it to work for all of the select tools on this dataset.

I suspect the problem dr is having is the selection tools now use contains rather than intersects by default. Maybe the best solution is to make intersects the default method for all selection tools. Then provide an option to change it to contains if the user prefers.

I have made a patch ​patch in #2938 that hopefully addresses this issue.

[gislab]

this would be really nice if it can work in both modes! I agree that default 'intersect' makes a lot of sense. Thanks for working on this.

[dr]

Seems to be fixed. 'Intersect' selection mode is default now.