Opened 14 years ago
Closed 13 years ago
#2534 closed bug (fixed)
avoid the possibility to enter -in attributes table- strings/numbers beyond the field length
Reported by: | lutra | Owned by: | sunilkcube |
---|---|---|---|
Priority: | major: does not work as expected | Milestone: | Version 1.7.0 |
Component: | Vectors | Version: | Trunk |
Keywords: | Cc: | ||
Must Fix for Release: | Yes | Platform: | All |
Platform Version: | Awaiting user input: | no |
Description
Actually you can enter values in the attributes table with a length that is > of the field length. This can be source of problems as a users can be mislead to believe the field has room for more chars/numbers than has really.
Fixing this will also indirectly fix another bug:
if the attributes table has only one row and you edit it, if you enter a value that has more chars/numbers than allowed by the field length, when you toggle editing to save changes, the value is not immediately truncated leading to believe that that particular edit went fine.
Attachments (4)
Change History (12)
comment:1 by , 14 years ago
Milestone: | Version 1.5.0 → Version 1.6.0 |
---|
comment:2 by , 14 years ago
comment:3 by , 13 years ago
Owner: | changed from | to
---|---|
Status: | new → assigned |
by , 13 years ago
Attachment: | patch_for_bug_#2534.txt added |
---|
by , 13 years ago
Attachment: | patch_for_bug_#2534.diff added |
---|
follow-up: 5 comment:4 by , 13 years ago
I have attached the patch file, Kindly reply your comments.
follow-up: 6 comment:5 by , 13 years ago
Replying to sunilkcube:
I have attached the patch file, Kindly reply your comments.
Looks good.
Just two things:
- the validator only returns Invalid or Acceptable, while the child validators might als return Intermediate.
- There doesn't seem to be support for (the configurable string representation of) NULL. If the value is some not yet complete part of NULL the validator should also return Intermediate and ignore the size limitations in that case.
comment:6 by , 13 years ago
Replying to jef:
Thank you very much for your valuable comments. I have attached a new patch file. Can you kindly verify whether the file carries all the necessary changes you have mentioned above and Will you please reply me in case of further changes?.
by , 13 years ago
Attachment: | Corrected_patch_for_bug_#2534.diff added |
---|
Corrected patch contains all corrections mentioned by jef
comment:7 by , 13 years ago
Cc: | added |
---|
comment:8 by , 13 years ago
Cc: | removed |
---|---|
Resolution: | → fixed |
Status: | assigned → closed |
applied heavly modified in r15566. Thanks.
The second part of the issue seems to be solved with 1.6.