Opened 14 years ago

Closed 14 years ago

#2046 closed patch (fixed)

-c option missing in v.out.ogr.pg

Reported by: dassau Owned by: rugginoso
Priority: minor: annoyance Milestone: Version 1.4.0
Component: GRASS Version: Trunk
Keywords: GRASS, PostGIS, Vector, Export Cc: pcav
Must Fix for Release: No Platform: All
Platform Version: Awaiting user input: no

Description

Hi,

I would like to see the -c option added to the v.out.ogr.pg module in the GRASS toolbox to be able to preserve islands.

Regards,

Otto

Attachments (1)

patch.tar.gz (817 bytes ) - added by lutra 14 years ago.
patch to add the -c flag

Download all attachments as: .zip

Change History (7)

comment:1 by dassau, 14 years ago

Priority: major: does not work as expectedminor: annoyance

comment:2 by lutra, 14 years ago

Resolution: invalid
Status: newclosed

I was trying to make a patch for this module in order to add the "-c" flag, just to discover that there is no such flag.

"v.out.ogr.pg.py --help" returns

Description:
 Export vector to PostGIS (PostgreSQL) database table.

Keywords:
 vector, export, database

Usage:
 v.out.ogr.pg.py input=name layer=value type=string[,string,...]
   olayer=string [host=string] [port=value] database=name [user=string]
   [password=string] [--verbose] [--quiet]

Flags:
 --v   Verbose module output
 --q   Quiet module output

Parameters:
     input   Name of input vector map
     layer   Number of input layer
             default: 1
      type   Feature type(s)
             options: point,kernel,centroid,line,boundary,area,face
    olayer   Name of output database table
      host   Host
              Host name of the machine on which the server is running.
      port   Port
              TCP port on which the server is listening, usually 5432.
  database   Database
              Database name
      user   User
              Connect to the database as the user username instead of the  default.
  password   Password
              Password will be stored in file!

so I guess that it is the manual page that is wrong.

comment:3 by lutra, 14 years ago

Cc: pcav added

comment:4 by dassau, 14 years ago

Resolution: invalid
Status: closedreopened

in GRASS the module "v.out.ogr" offers a flag -c: It says:

  • to export features with category (labeled) only. Otherwise all features are exported

AFAICS in src/plugins/grass/scripts/ the module v.out.ogr.pg.py uses v.out.ogr. So the flag option -c should be added to the script and then also to the GRASS Toolbox.

Otto

by lutra, 14 years ago

Attachment: patch.tar.gz added

patch to add the -c flag

comment:5 by lutra, 14 years ago

Type: enhancementpatch

Ok, I attached here the necessary patches. I guess Paolo will commit them as soon as he will be back.

comment:6 by pcav, 14 years ago

Resolution: fixed
Status: reopenedclosed

Applied in r12473

Note: See TracTickets for help on using tickets.