Opened 15 years ago

Closed 15 years ago

Last modified 15 years ago

#1525 closed bug (fixed)

graticule creator: don't use reserved SQL words as column names

Reported by: neteler Owned by: nobody
Priority: critical: causes crash or data corruption Milestone:
Component: Vectors Version: 1.0.0
Keywords: graticule Cc:
Must Fix for Release: No Platform: All
Platform Version: Awaiting user input: no

Description

The changeset r8183 introduced the use of a reserved SQL word ('Column') as column name which renders the import of a graticule (SHAPE) file rather hard:

GRASS 6.5.svn (latlong_tbe_climate):~ > v.in.ogr italy_white_box_LL.shp out=italy_white_box_LL
Projection of input dataset and current location appear to match
Layer: italy_white_box_LL
DBMI-DBF driver error:
SQL parser error: syntax error, unexpected COLUMN, expecting NAME processing 'Column'
in statement:
create table italy_white_box_LL (cat integer, LabelX double precision, LabelY double precision, LblOffsetX integer, LblOffsetY integer, Label varchar ( 80 ), Row varchar ( 80 ), Column varchar ( 80 ), RowCol varchar ( 80 ))
Error in db_execute_immediate()

ERROR: Unable to create table: 'create table italy_white_box_LL (cat
       integer, LabelX double precision, LabelY double precision,
       LblOffsetX integer, LblOffsetY integer, Label varchar ( 80 ), Row
       varchar ( 80 ), Column varchar ( 80 ), RowCol varchar ( 80 ))'

Ref: http://developer.mimer.com/validator/sql-reserved-words.tml

Please select a different column name - suggestion: e.g., add a preceding "g" for graticule.

Change History (5)

comment:1 by neteler, 15 years ago

Apparently the graticule creator no longer exists and is replaced with the (external only?) ftools.

Personally I feel that in a *release* branch tools should not be removed without built-in replacement. Either ftools need to be added or the graticule creator be restored in 1.0.x.

comment:2 by pcav, 15 years ago

Resolution: fixed
Status: newclosed

comment:3 by neteler, 15 years ago

OK, but I am on Version 1.0.x... cannot find it there.

in reply to:  3 comment:4 by jef, 15 years ago

Replying to neteler:

OK, but I am on Version 1.0.x... cannot find it there.

but in 1.0 it's still there. fixed in r10258

comment:5 by (none), 15 years ago

Milestone: Version 1.0.2

Milestone Version 1.0.2 deleted

Note: See TracTickets for help on using tickets.