Opened 15 years ago

Closed 15 years ago

#1489 closed bug (fixed)

GRASS Plugin: Map name input field not working correctly for modules that take multiple input maps

Reported by: benducke Owned by: rugginoso
Priority: major: does not work as expected Milestone: Version 1.0.3
Component: GRASS Version: Trunk
Keywords: GRASS, multiple, map names Cc: neteler
Must Fix for Release: No Platform: All
Platform Version: Awaiting user input: no

Description

E.g.: open the "r.patch" module dialog. You will see the "Type in map names .." field, which works just fine. But the "[...]" browse button takes the user to a "Save As" dialog, which is completely dysfunctional in this context. What it should open is a widget that allows users to select one or more maps in the current GRASS mapset. If that is too much work to go into QGIS 1.0.0, I'd suggest getting rid of that button altogether. It will be a little inconvenient for the user having to manually type in map names, but still better than popping up a misleading dialog.

Change History (6)

comment:1 by neteler, 15 years ago

Platform: DebianAll

I have tried:

svn diff src/plugins/grass/modules
Index: src/plugins/grass/modules/r.patch.qgm
===================================================================
--- src/plugins/grass/modules/r.patch.qgm       (revision 10412)
+++ src/plugins/grass/modules/r.patch.qgm       (working copy)
@@ -4,6 +4,6 @@
 <qgisgrassmodule label="Create new raster by combining other rasters" module="r.patch">
        <option key="input"/>
        <flag key="z" answer="off" hidden="no" />
-       <file key="input" label="Type in map names separated by a comma" />
+       <option key="input" label="Alternatively, type in map names separated by comma" />
        <option key="output" />
 </qgisgrassmodule>

but this leads to a selector (no more free text field). Maybe there is something else than "file" or "option" which creates a free text field without the button behind it?

Markus

comment:2 by neteler, 15 years ago

Cc: neteler added

comment:3 by rugginoso, 15 years ago

Resolution: fixed
Status: newclosed

Fixed in r10945. See the r.path.qgm module to use the new feature into the other modules that require it.

comment:4 by pcav, 15 years ago

Resolution: fixed
Status: closedreopened

comment:5 by pcav, 15 years ago

Owner: changed from nobody to rugginoso
Status: reopenednew

comment:6 by pcav, 15 years ago

Resolution: fixed
Status: newclosed
Note: See TracTickets for help on using tickets.