Opened 15 years ago

Last modified 13 years ago

#1473 reopened patch

3dz/3dm/4d support

Reported by: jef Owned by: jef
Priority: minor: annoyance Milestone: Version 1.7.0
Component: Vectors Version: Trunk
Keywords: Cc: bitner@…
Must Fix for Release: No Platform: All
Platform Version: Awaiting user input: no

Description

attached a patch that add 3dz/3dz/4d vector support to core and the postgres provider.

Attachments (3)

2d+.diff (146.6 KB ) - added by jef 15 years ago.
2d+.diff.gz (49.1 KB ) - added by jef 15 years ago.
sampletracks.tar.gz (24.0 KB ) - added by bitner 13 years ago.
Shapefile with Z and M Coordinates

Download all attachments as: .zip

Change History (17)

comment:1 by jef, 15 years ago

Summary: 3dz/3dz/4d support3dz/3dm/4d support

by jef, 15 years ago

Attachment: 2d+.diff added

comment:2 by wonder, 15 years ago

Hi Juergen, I've took a brief look on your patch - I see there's quite big amount of work in it! :)

From the technical side, may I suggest you to leave QgsPoint as class for 3D points (X,Y,Z) and derive QgsPointM class from it which would operate also with M coordinates? I have the impression that these 'measure' dimension is used so rarely that it would cause unnecessary memory overhead in usual case.

Martin

comment:3 by pcav, 15 years ago

Would this be the right time to apply this patch to svn?

comment:4 by jef, 15 years ago

I was about to update the patch - but it has grown to large to attach. I uploaded it to http://buten.norbit.de/~jef/2d+.diff.

The patch now contains rewritten WKB parsing and creation code and uses QVector instead of QList to keep points. It reduces the need for reallocations and copying of memory.

in reply to:  4 comment:5 by jef, 15 years ago

Replying to jef:

I uploaded it to http://buten.norbit.de/~jef/2d+.diff.

updated the patch to r10066

comment:6 by pcav, 15 years ago

Milestone: Version 1.0.1

by jef, 15 years ago

Attachment: 2d+.diff.gz added

comment:7 by lutra, 15 years ago

If the patch has been applied can I close this?

comment:8 by lutra, 15 years ago

Resolution: fixed
Status: newclosed

The patch should have been applied, so I'm closing this ticket. Reopen if necessary.

comment:9 by jef, 15 years ago

Resolution: fixed
Status: closedreopened

this patch has not been applied.

in reply to:  9 ; comment:10 by jef, 15 years ago

Replying to jef:

this patch has not been applied.

I've no application for 2d+ data - and therefore this hasn't been tested enough to be applied.

in reply to:  10 comment:11 by lutra, 15 years ago

Replying to jef:

Replying to jef:

this patch has not been applied.

I've no application for 2d+ data - and therefore this hasn't been tested enough to be applied.

Hi Jürgen,

thanks for the feedback. Is this on the developers agenda for the next future?

comment:12 by bitner, 14 years ago

Cc: bitner@… added
Milestone: Version 1.0.3

I am happy to provide either testing or sample datasets for this feature if it gets pulled back up. This is very important for anyone who needs to carry through Z and M data even if they are not using it in all situations.

comment:13 by pcav, 14 years ago

Milestone: Version 1.6.0

bitner (or others), please provide sample data for testing and eventually apply the patch

in reply to:  13 comment:14 by bitner, 13 years ago

Replying to pcav:

bitner (or others), please provide sample data for testing and eventually apply the patch

Just now saw this.... Attaching a shapefile that has Z and M Coordinates. (shp2pgsql will bring it in with Z and M dimensions intact -- OGR will drop them)

by bitner, 13 years ago

Attachment: sampletracks.tar.gz added

Shapefile with Z and M Coordinates

Note: See TracTickets for help on using tickets.