Opened 18 years ago

Closed 17 years ago

Last modified 15 years ago

#140 closed bug (fixed)

Color selection buttons do not show selected color

Reported by: jpalmer Owned by: morb_au
Priority: minor: annoyance Milestone:
Component: GUI Version: 0.8
Keywords: Cc:
Must Fix for Release: No Platform: Windows
Platform Version: winxp sp2 Awaiting user input: no

Description

In the 2006-06-05 win32 build of qgis, in the options dialog, the selection color and background color buttons do no show the currently selected color.

Change History (8)

comment:1 by anonymous, 18 years ago

Owner: changed from rblazek to gsherman

Currently I dont work on Win build, assigned to Gary.

comment:2 by morb_au, 18 years ago

Owner: changed from gsherman to morb_au
Priority: majorminor
Status: newassigned

QToolButton::setPaletteBackgroundColor() is being used to colour the buttons, but appears to be a Qt3 idiom. While the Qt3support might be OK for X11, maybe TrollTech tested it less thoroughly on Windows.

I will try converting it to Qt4 and committing to subversion soon, but somebody else will need to recompile it for Windows.

comment:3 by morb_au, 18 years ago

Owner: changed from morb_au to gsherman
Status: assignednew

Potential fix in r5696.

Can somebody with access to a compiler for the Windows version please re-build and test? The setPaletteBackgroundColor idiom exists in more than just the options dialog, and all instances should be replaced before this ticket is closed.

Reassigning to gsherman as he was last seen with a Windows build. (-:

comment:4 by morb_au, 18 years ago

Owner: changed from gsherman to morb_au
Status: newassigned

As of a private Windows build based on r5815, the potential fix does not work. I will attempt some more research in due course.

comment:5 by morb_au, 18 years ago

A real fix is applied in subversion r5871, but only covers the buttons in the Options and Project Properties dialogs at this time. My Windows 2003 SP1 setup confirms these changes work.

Other dialogs to follow.

Also, the Qt documentation implies this problem also occurs on Mac OS. Can somebody with that OS confirm?

comment:6 by cavallini@…, 18 years ago

I confirm the problem on many XP boxes (preview2). If someone is able to compile a preview3, I can do more testing.

comment:7 by g_j_m, 17 years ago

Must Fix for Release: No
Resolution: fixed
Status: assignedclosed

All of the colour buttons that I could find appear to be fixed (in the latest window build).

comment:8 by (none), 15 years ago

Milestone: Version 0.8

Milestone Version 0.8 deleted

Note: See TracTickets for help on using tickets.