Opened 16 years ago

Closed 15 years ago

#1325 closed bug (fixed)

Multipoint layer problems - zoom to selection doesn't work; layer extent has wild values on editing

Reported by: smizuno Owned by: nobody
Priority: major: does not work as expected Milestone: Version 1.0.3
Component: Vectors Version: Trunk
Keywords: Cc: pcav
Must Fix for Release: Yes Platform: All
Platform Version: Awaiting user input: no

Description

Vector layers of type Multipoint have the following problems:

  1. Zoom to selection doesn't do anything.
  1. When editing - adding or deleting points - the extent as shown in properties, Metadata goes to some wild values.

This causes zoom to layer extent to zoom to a very small scale, such that the scale bar on the map shows a distance on the order of 1e+200km

The points added are correctly positioned. Reloading the layer fixes the extents display.

some examples of the extents shown in Metadata (layer has a few points over about 1000m):

start: xMin,yMin 499999,5e+06 : xMax,yMax 501001,5.001e+06
add point: xMin,yMin 499999,-1.51934e-93 : Max,yMax2.95439e+202,5.001e+06

xMin,yMin 499999,5e+06 : xMax,yMax 1.09228e+209,1.2796e+156

delete point: xMin,yMin 4.94066e-324,-2 : xMax,yMax 4.94066e-324,2

I have tested with PostGIS and shapefiles.

Expected behaviors: Zoom to selection operates as it does for Points - a single point is displayed at a fairly large scale; multiple points should be displayed over most of the map view.

On add and delete points the extents should reflect the minimum/maximum of the locations of the layer.

Attachments (1)

patch_for_1325.txt (591 bytes ) - added by smizuno 15 years ago.
fix multipoint extent problem

Download all attachments as: .zip

Change History (6)

comment:1 by smizuno, 15 years ago

Type: bugpatch

I provide a patch for QgsGeometry to fix the above problems.

The details:

  1. have found in boundingBox() that an increment of ptr to the beginning of the point array was missing, so the points retrieved had wild values.
  1. and on a cursory inspection of the class I found in deleteVertext() that there is a missing break statement in the WKBMultiPoint case - there is a TODO note, but the case just fell through to the next, potentially causing odd problems.

by smizuno, 15 years ago

Attachment: patch_for_1325.txt added

fix multipoint extent problem

comment:2 by mhugent, 15 years ago

Applied in r9753. thanks! Still it would be good to implement the delete vertex method for multipoints.

comment:3 by jef, 15 years ago

Type: patchbug

comment:4 by lutra, 15 years ago

Cc: pcav added

If the patch has already been applied can we close this ticket?

comment:5 by smizuno, 15 years ago

Resolution: fixed
Status: newclosed

Yes, as the reported problem has been fixed.

Note: See TracTickets for help on using tickets.