script errors

[blq]

Hi, I tried to compile Proj4js (current trunk) using the Google Closure JavaScript compiler, ​http://code.google.com/closure/compiler/. Using the VERBOSE mode it found a bunch of errors, mostly related to use of undefined variables.

Applying the attached patch the most obvious errors are fixed and you get a "successful" compilation. But, I'd say it's better if you do the compilation yourselves and inspect the output step by step to ensure the correctness. There's still a couple of most-likely bugs left although they appear only as warnings. For example use of a "this.phi0", "this.at1" and "c" that doesn't seem to be declared, "this.gam" vs "this.gama", qsfnz() is called with three args but only take two etc.

Here's the command line I used: "java -jar closure.jar --js Proj4js-combined.js --warning_level VERBOSE --js_output_file compiled_proj4s-combined.js"

If you manage to navigate around the massive amounts of "dangerous use of the global this object" warnings you find the more serious bugs!

As a nice side-effect the output from Closure is a 15kb smaller file.

Regards / Fredrik Blomqvist

[blq]

patch for proj4js-combined.js that fixes errors found using Closure compiler.

[blq]

Noticed that you can add "--jscomp_off globalThis" to the command line to silence the huge number of that, in this case, non-critical warning.

[blq]

..bump. Any updates?

[madair]

I will include this with a new release around a license change in the near future

[blq]

Great, thanks.

[madair]

modified patch applied at rev 2203

[madair]

Milestone 1.0.4 deleted

[blq]

I can see you updated the package now, thanks! But please see if you can investigate the remaining handful of warnings when set to compile using VERBOSE mode (VERBOSE finds more errors, it's not just how much is printed to the log).

For example, in the inverse polyconic projection there's a 'c' variable that is used in the calculations despite never being set. (add --jscomp_off globalThis to filter out the unimportant warning).

[blq]

adds Closure VERBOSE mode compilation.

[blq]

Attached a new patch: proj4js_closure.patch (relative the new 1.1.0 trunk). It adds verbose compilation (and couple of trivial edits to remove a handful of non-critical warnings to reduce log noise). The warnings that are output now I'd say needs some further investigation.

Regards / Fredrik Blomqvist

[madair]

seen the light on benefits of using the google closure compiler.

will be working using use plovr for building this library similar to what is being used for ol3

[blq]

Nice. Please note that you should strive to use the "--warning_level VERBOSE" setting to catch "all" warnings (see my patch above).

[madair]

I have created a branch for this work here ​http://svn.osgeo.org/metacrs/proj4js/branches/closure Note I've only brought over the lcc.js projection class at this point. Once the correct pattern is defined, we can apply to all other projection classes.

It mostly works, but not in ADVANCED compilation mode because some symbols are not properly exported. Help with getting the annotations correctly defined is needed

[madair]

this work is now being carried out on github, ​https://github.com/proj4js/proj4js

new issues can be opened on github