PG16 failing unrecognized configuration parameter "force_parallel_mode"

[robe]

I thought this was a PG16 building issue, but I think they removed force parallel mode:

18:11:29  regress/core/tickets .. failed (diff expected obtained: /var/lib/jenkins/workspace/postgis/tmp/3_4_pg16w64/test_85_diff)
18:11:34 -----------------------------------------------------------------------------
18:11:34 --- ./regress/core/tickets_expected	2023-03-08 01:57:17.656165431 +0000
18:11:34 +++ /var/lib/jenkins/workspace/postgis/tmp/3_4_pg16w64/test_85_out	2023-04-20 22:11:34.108224927 +0000
18:11:34 @@ -276,8 +276,8 @@
18:11:34  #3172|LINESTRING M (0 0 1,0 0 2)
18:11:34  #3300|POLYGON((-71.7821 42.2622,-71.7821 42.9067,-71.029 42.9067,-71.029 42.2622,-71.7821 42.2622))
18:11:34  #3355|t
18:11:34 -#3356|LineString[] with 2 points|LineString[GS] with 2 points|LineString[GS] with 2 points
18:11:34  #3356|LineString[B] with 3 points|LineString[BGS] with 3 points|LineString[BGS] with 3 points
18:11:34 +#3356|LineString[] with 2 points|LineString[GS] with 2 points|LineString[GS] with 2 points
18:11:34  #3367|POLYGON EMPTY
18:11:34  #3368|\x660001011fb98788d35ed6fbcdc831c580012b959f01469d8d0e9305ff8618ed08b1b607e302a614fe70bc4682b303b4379ab503a228eeb603e2138eb802900cc0b802ba04dab802b801a8840cb0229cca06f401c216f403a016ea05d0c301a8b301cc189226ac15ee27f811a029b40eac2ae00a902b8407c82b9e03d0e305801dfad3239504ce7e8d01e2f701f6019b04d1e2279bf901ff01
18:11:34  #3375|GEOMETRYCOLLECTION(POINT(0 -7))
18:11:34 @@ -463,7 +463,9 @@
18:11:34  #5008|f|f
18:11:34  ERROR:  Line has no points
18:11:34  #5350|M 0 0 l 1 -1
18:11:34 +ERROR:  unrecognized configuration parameter "force_parallel_mode"
18:11:34  #5139|100000
18:11:34  #5139|1000000
18:11:34 +ERROR:  unrecognized configuration parameter "force_parallel_mode"
18:11:34  ERROR:  Geometry contains invalid coordinates
18:11:34  ERROR:  Geometry contains invalid coordinates
18:11:34 -----------------------------------------------------------------------------
18:11:34  regress/core/twkb .. ok in 65 ms
18:11:34  regress/core/typmod .. ok in 6834 ms
18:11:41  regress/core/wkb .. ok in 79 ms
18:11:41  regress/core/wkt .. ok in 87 ms
18:11:41  regress/core/wmsservers .. ok in 235 ms
18:11:41  regress/core/offsetcurve .. ok in 61 ms
18:11:41  regress/core/relatematch .. ok in 52 ms
18:11:41  regress/core/isvaliddetail .. ok in 55 ms
18:11:41  regress/core/sharedpaths .. ok in 72 ms
18:11:42  regress/core/snap .. ok in 50 ms
18:11:42  regress/core/node .. ok in 53 ms
18:11:42  regress/core/unaryunion .. ok in 54 ms
18:11:42  regress/core/union .. failed (diff expected obtained: /var/lib/jenkins/workspace/postgis/tmp/3_4_pg16w64/test_98_diff)
18:11:42 -----------------------------------------------------------------------------
18:11:42 --- ./regress/core/union_expected	2022-08-22 20:53:14.519685332 +0000
18:11:42 +++ /var/lib/jenkins/workspace/postgis/tmp/3_4_pg16w64/test_98_out	2023-04-20 22:11:42.860196833 +0000
18:11:42 @@ -4,6 +4,7 @@
18:11:42  t
18:11:42  POINT EMPTY
18:11:42  POLYGON EMPTY
18:11:42 +ERROR:  unrecognized configuration parameter "force_parallel_mode"
18:11:42  400|0|0|20|20
18:11:42  400|0|0|20|20
18:11:42  t
18:11:42 -----------------------------------------------------------------------------

I suspect GHA would be failing at this step too, but is stuck on the CUnit tests #5366 on raster so never gets to this point.

[robe]

This is caused by commit - ​https://git.postgresql.org/gitweb/?p=postgresql.git;a=commit;h=0981846b9c3ab1dcc351798dcae6a2e35872a6c3

They renamed force_parallel_mode to debug_parallel_query

[Regina Obe <lr@…>]

In bff92ecd/git:

PG16 regression fixes

• Use debug_parallel_query instead of force_parallel_mode for PG16 and above
• Address PG16 sorting of text behavior change for (tickets)

References #5374 for PostGIS 3.4.0
References #5475 for PostGIS 3.4.0

[robe]

An alternative to using procedure would have been to use update as RhodiumToad (Andrew) suggested on IRC.

update pg_settings set setting = 'on' where name in ('debug_parallel_query','force_parallel_mode');

Then version wouldn't matter. Right now can only be backported to 3.3 since I'm using procedures introduced in PG 11

[Regina Obe <lr@…>]

In 76f44de/git:

Support build on Pg16devel for PostGIS 3.3.3

Closes #5257
Closes #5261
Closes #5277
Closes #5308
Closes #5374
Closes ​https://github.com/postgis/postgis/pull/716