Upgrade failures on 2.5 to 3.3.0

[robe]

Noticed on master that dronie is failing on upgrades from

NOTICE:  schema "public" already exists, skipping

CREATE SCHEMA

SET

CREATE TABLE

INSERT 0 2

DO

CREATE VIEW

CREATE VIEW

CREATE VIEW

CREATE VIEW

CREATE VIEW

CREATE VIEW

CREATE VIEW

UPDATE 479

ERROR:  Trying to add OPERATOR CLASS spgist_geometry_ops_nd USING SPGIST to postgis, got operator class "spgist_geometry_ops_nd" does not exist for access method "spgist" (42704)

CONTEXT:  PL/pgSQL function inline_code_block line 25 at RAISE

-----------------------------------------------------------------------------

/drone/src/regress/runtest.mk:22: recipe for target 'check-regress' failed

make: Leaving directory '/tmp/postgis-build/11/regress'

FAIL: postgis extension upgrade unpackaged2.5--3.3.0beta2!

upgrade unpackaged2.5—3.3.0beta2!

As noted in ​https://dronie.osgeo.org/postgis/postgis/3240/1/3

[robe]

At a glance looks like the issue started with this ​https://dronie.osgeo.org/postgis/postgis/3229/1/4

Check for ownership mismatch in regress test

[robe]

Hmm that can't be it, that is just on your fork.

[strk]

I see what it is, about to push a fix

[Sandro Santilli <strk@…>]

In 322daf2/git:

Survive upgrades adding operator class (and other object kinds)

Closes #5187

[strk]

for the record: commit [322daf2ad0ad0ffe8fe250a572fe495235649500/git] had a syntax error which was fixed on the next commit [6f3c183e6f81e2c823235d26929166deb2c982d8/git]

[strk]

Reopening as now we backported the upgrade support after CVE-2022-2625 PostgreSQL fix (see #5209 and #5210) the problem also exists in older branches. Up to 2.5

[Sandro Santilli <strk@…>]

In 996158e/git:

Survive upgrades adding operator class (and other object kinds)

References #5187 in 3.2 branch (3.2.3dev)

[Sandro Santilli <strk@…>]

In 84cc88c/git:

Survive upgrades adding operator class (and other object kinds)

References #5187 in 2.5 branch (2.5.8dev)

[Sandro Santilli <strk@…>]

In bddde7f/git:

Survive upgrades adding operator class (and other object kinds)

References #5187 in 3.1 branch (3.1.7dev)

[Sandro Santilli <strk@…>]

In 6e4c43df/git:

Survive upgrades adding views and tables

References #5187 in 2.5 branch (2.5.8dev)

[Sandro Santilli <strk@…>]

In 40c8f25a/git:

Survive upgrades adding operator class (and other object kinds)

References #5187 in 3.1 branch (3.1.7dev)

[Sandro Santilli <strk@…>]

In cebb4097/git:

Survive upgrades adding views and tables

References #5187 in 3.0 branch (3.0.7dev)

[Sandro Santilli <strk@…>]

In c8a49a1/git:

Survive upgrades adding views and tables

References #5187 in 3.1 branch (3.1.7dev)

[Sandro Santilli <strk@…>]

In 50932f3/git:

Survive upgrades adding views and tables

References #5187 in 3.2 branch (3.2.3dev)

[Sandro Santilli <strk@…>]

In a903b04e/git:

Survive upgrades adding views and tables

Closes #5187 in master branch (3.3.0dev)

[strk]

Replying to Sandro Santilli <strk@…>:

In 40c8f25a/git:

Survive upgrades adding operator class (and other object kinds)

References #5187 in 3.1 branch (3.1.7dev)

For the record: the above commit [40c8f25a/git] was in 3.0 branch (3.0.7dev) not 3.1 as written in the commit log. I've pushed a note to mention it in git history but Trac doesn't show it. Gitea instead does: ​https://git.osgeo.org/gitea/postgis/postgis/commit/40c8f25a0fe041427b111ed133d573b553e1ce53