2.5.6dev--3.3.0dev upgrade fails: cannot change name of input parameter "param_geom"

[strk]

$ regress/run_test.pl --extension --upgrade --upgrade-path 2.5.6dev--3.3.0dev regress/core/regress -v
[...]
Preparing db 'postgis_reg' using: CREATE EXTENSION postgis VERSION '2.5.6dev' SCHEMA public
Upgrading from postgis 2.5.6dev
Running before-upgrade-script ../regress/hooks/hook-before-upgrade.sql
Upgrading PostGIS in 'postgis_reg' using: ALTER EXTENSION postgis UPDATE TO '3.3.0dev'
 failed (Error encountered updating EXTENSION POSTGIS: /tmp/pgis_reg/regress_log)
-----------------------------------------------------------------------------
NOTICE:  schema "public" already exists, skipping
CREATE SCHEMA
CREATE EXTENSION
NOTICE:  schema "public" already exists, skipping
CREATE SCHEMA
SET
CREATE TABLE
INSERT 0 2
DO
CREATE VIEW
CREATE VIEW
CREATE VIEW
CREATE VIEW
CREATE VIEW
CREATE VIEW
UPDATE 592
WARNING:  unpackaging raster
WARNING:  PostGIS Raster functionality has been unpackaged
HINT:  type `SELECT postgis_extensions_upgrade();` to finish the upgrade. After upgrading, if you want to drop raster, run: DROP EXTENSION postgis_raster;
ERROR:  cannot change name of input parameter "param_geom"
HINT:  Use DROP FUNCTION st_concavehull(geometry,double precision,boolean) first.
-----------------------------------------------------------------------------

[strk]

Paul I believe this is you changing the name of a parameter ? See commit [0f2afd2ac3/git]

[strk]

NOTE: the problem occurs ONLY when using a new enough GEOS. For example Dronie does not fail the upgrade, while using GEOS-3.6: ​https://dronie.osgeo.org/postgis/postgis/2713/1/4

[strk]

Availability and Changed comments should also be updated, or docs would think (when you have newer geos) that ST_ConcaveHull was introduced in 3.3.0 instead of 2.0.0

[strk]

We could also think about a Replaces comment if that's were we're going, but maybe the old implementation should go in the C file as well, to simplify things.

[Sandro Santilli <strk@…>]

In a8de642/git:

Do not change ST_ConcaveHull signature

Fixes #5078

[Sandro Santilli <strk@…>]

In a8de642/git:

Do not change ST_ConcaveHull signature

Fixes #5078

[strk]

Reopening as it looks like the old signature is just NOT compatible with the C implemented version of the function, see ​https://trac.osgeo.org/postgis/ticket/5079#comment:5

[pramsey]

Your fix is fine, I'm re-closing this.