Context Navigation

← Previous Ticket
Next Ticket →

#5077 closed defect (fixed)

Upgrading from PostGIS 2.4.9 to master (3.3.0dev) on PG12 results in error

Reported by:	robe	Owned by:	robe
Priority:	blocker	Milestone:	PostGIS 2.4.10
Component:	QA/buildbots	Version:	2.4.x
Keywords:		Cc:

Description (last modified by robe)

It seems on dronie, we managed to get a PostGIS with 2.4.9 installed in PG12. https://dronie.osgeo.org/postgis/postgis/2702/1/6

Now that we made PG12 live, it is trying to upgrade from PG 12 2.4.9 to 3.3.0dev

and failing on topology. This looks like issue with changes made in PG12 they took out. I think we had fixed the views for geography_columns and geometry_columns. So I suspect a similar change can be made on topology.

CREATE FUNCTION
2147s
28875psql:/usr/share/postgresql/12/contrib/postgis-2.4/topology.sql:822: NOTICE:  function topology.populate_topology_layer() does not exist, skipping
2147s
28876DROP FUNCTION
2147s
28877psql:/usr/share/postgresql/12/contrib/postgis-2.4/topology.sql:856: ERROR:  column c.consrc does not exist
2147s
28878LINE 11:     regexp_matches(c.consrc,
2147s
28879                            ^
2147s
28880HINT:  Perhaps you meant to reference the column "c.conkey" or the column "c.conbin".
2147s
28881NOTICE:  schema "public" already exists, skipping
2147s
28882CREATE SCHEMA
2147s
28883SET
2147s
28884psql:/usr/share/postgresql/12/contrib/postgis-2.4/topology_comments.sql:2: ERROR:  type "topology.getfaceedges_returntype" does not exist
2147s
28885NOTICE:  schema "public" already exists, skipping
2147s
28886CREATE SCHEMA
2147s
28887SET
2147s
28888psql:/drone/src/topology/test/regress/hooks/hook-before-upgrade-topology.sql:1: ERROR:  function topology.createtopology(unknown) does not exist
2147s
28889LINE 1: SELECT topology.createTopology('upgrade_test');
2147s
28890               ^
2147s
28891HINT:  No function matches the given name and argument types. You might need to add explicit type casts.
2147s
28892-----------------------------------------------------------------------------
2147s
28893/drone/src/regress/runtest.mk:22: recipe for target 'check-regress' failed
2147s
28894make: Leaving directory '/tmp/postgis-build/12/topology/test'
2147s
28895FAIL: postgis_topology upgrade unpackaged2.4--3.3.0dev!

Change History (13)

comment:1 by robe, 3 years ago

Description:	modified (diff)

comment:2 by strk, 3 years ago

Can be reproduced with:

regress/run_test.pl -v --topology --extension --upgrade --upgrade-path unpackaged2.4--3.3.0dev topology/test/regress/addface

comment:3 by strk, 3 years ago

NOTE: it is not _upgrading_ that fails, but LOADING 2.4 into PG12

comment:4 by strk, 3 years ago

Actually, not even loading, but invoking the pre-upgrade script. So 2.4 does load, but fail running some function

comment:5 by Sandro Santilli <strk@…>, 3 years ago

In 1fd865f6/git:

[dronie] Stop testing PG12 for now

References #5077

comment:6 by strk, 3 years ago

So I had Drone stop testing PG12 and createad a PR to re-enable it (when it's fixed): https://git.osgeo.org/gitea/postgis/postgis/pulls/85

comment:7 by strk, 3 years ago

Component:	topology → buildbots
Owner:	changed from strk to robe

According to https://trac.osgeo.org/postgis/wiki/UsersWikiPostgreSQLPostGIS PostGIS-2.4 does not support PostgreSQL 12 so this becomes a CI-specific ticket

comment:8 by strk, 3 years ago

For the record: the consrc issue was reported in #4231 and fixed in PostGIS-3.0.0 (in case we want to backport the fix, but I don't think it is worth it?)