Opened 3 years ago
Closed 3 years ago
#5044 closed defect (wontfix)
make pull-tx drops translated strings
Reported by: | strk | Owned by: | robe |
---|---|---|---|
Priority: | medium | Milestone: | PostGIS 3.3.0 |
Component: | l18n | Version: | 3.2.x |
Keywords: | Cc: |
Description
As of commit [b67f6c80f24edb57fa223a2065c2255bbb346cef/git] running make pull-tx
results in removal of translated strings in some files.
Example:
--- a/doc/po/de/introduction.xml.po +++ b/doc/po/de/introduction.xml.po @@ -66,13 +66,6 @@ msgid "" "(coverages, surfaces, networks), data source for desktop user interface " "tools for viewing and editing GIS data, and web-based access tools." msgstr "" -"Die PostGIS Project Develpment Group beabsichtigt durch die Unterstützung " -"und Weiterentwicklung von PostGIS eine hohe Funktionsvielfalt zu erreichen. " -"Diese soll wichtige GIS-Funktionalitäten, Kompatibilität mit den spatialen " -"Standards OpenGIS und SQL/MM, hochentwickelte topologische Konstrukte " -"(Coverages, Oberflächen, Netzwerke), Datenquellen für Desktop " -"Benutzeroberflächen zum Darstellen und Bearbeiten von GIS Daten, sowie " -"Werkzeuge für den Zugriff via Internettechnologie beinhalten." #. Tag: title #: introduction.xml:21
As I just pushed to transifex after the aforementioned commit I don't understand why would a pull drop those strings, unless someone really logged into Transifex to remove them, which is unlikely.
Other changes are the Last-Translator
header, which goes to me (probably just because I was the last pusher) and removal of some fuzzy
labels.
I wonder if what Transifex is doing is basically DROP the "fuzzy" strings, not trusting them (--no-fuzzy-matching
switch used by Transifex use of msgmerge
whereas our own update-po
does not make use of that switch?)
Change History (5)
comment:1 by , 3 years ago
comment:2 by , 3 years ago
Component: | documentation → l18n |
---|
comment:3 by , 3 years ago
I found the reason for this being that our make pull-tx
does NOT pass a --mode
switch to tx
commandline, which by default means --mode developer
, which in turn does NOT download translation which were NOT reviewed.
For switching to weblate we probably want to fetch more strings. Available modes are documented in https://docs.transifex.com/client/pull/
I'll experiment some with different modes to try at finding something that works for us w/out introducing too many conflicts
comment:4 by , 3 years ago
I tried different modes but none of them give us what we need.
I guess the only proper solution is fetching the transifex files with untranslated string empty and then use msgcat
to merge the transifex one and our one: https://phrase.com/blog/posts/combine-po-translation-files/
comment:5 by , 3 years ago
Resolution: | → wontfix |
---|---|
Status: | new → closed |
With commit [26d51b23a1f967771df731b91bba5fd5e3cd735e/git] I removed the Transifex support from our build scripts, so this is going to be a wontfix
I tried using
msgmerge --no-fuzzy-matching
on my system but I still don't obtain the same result obtained from pulling from Transifex.Weblate still has the removed-by-transifex strings: https://weblate.osgeo.org/translate/postgis/introductionxml/de/?offset=&q=Develpment+Group+beabsichtigt+durch&sort_by=-priority%2Cposition&checksum=
But also Transifex seems to know about them: https://www.transifex.com/postgis/postgis/translate/#de/introductionxmlpot_1/179231423?q=text%3A'coverages%2C+surfaces%2C+networks'