Opened 4 years ago

Closed 4 years ago

#4781 closed defect (fixed)

winnie and windows failures on raster

Reported by: robe Owned by: strk
Priority: blocker Milestone: PostGIS 3.1.0
Component: build Version: master
Keywords: Cc:

Description

I should note I'm having similar issue to winnie with failing raster tests. Both of us are running GDAL 3.2.0 RC1

Seemed to start failing after

Commit 402fdc0e8191422b23996eafde93b2dce33c1595 by Sandro Santilli

Run all regress tests in the same database

Speeds up regression testing and catches some issues in presence
of multiple components in the same db.

Still allows running individual testsuites from within their
respective directory.

Last error log: https://winnie.postgis.net:444/job/PostGIS_EDB_Regress_winnie/11278/consoleFull

Error looks like this:

PostgreSQL 11.7, compiled by Visual C++ build 1914, 64-bit
  Postgis 3.1.0dev - (3.1.0alpha2-130-g812ab8609) - 2020-11-02 23:22:21
  scripts 3.1.0dev 3.1.0alpha2-130-g812ab8609
  raster scripts 3.1.0dev 3.1.0alpha2-130-g812ab8609
  GEOS: 3.9.0-CAPI-1.14.0
  PROJ: 6.3.2
  SFCGAL: 1.3.8
  GDAL: GDAL 3.2.0, released 2020/10/26

Running tests
:
:
 ./raster/test/regress/check_gdal .. ok in 780 ms
 ./raster/test/regress/load_outdb . failed (Failed evaluating ./raster/test/regress/load_outdb-pre.pl: ./raster/test/regress/load_outdb: No such file or directory at ./raster/test/regress/load_outdb-pre.pl line 60.)
 ./raster/test/regress/check_raster_columns .. ok in 696 ms
 ./raster/test/regress/check_raster_overviews .. ok in 567 ms
 ./raster/test/regress/rt_io .. ok in 1014 ms
 ./raster/test/regress/rt_bytea .. ok in 1201 ms
 ./raster/test/regress/rt_wkb .. failed (diff expected obtained: /projects/postgis/tmp/3.1.0dev_pg11_geos3.9_gdal3.2.0w64/test_198_diff)
-----------------------------------------------------------------------------
--- ./raster/test/regress/rt_wkb_expected	2020-11-02 18:19:50.817116300 -0500
+++ /projects/postgis/tmp/3.1.0dev_pg11_geos3.9_gdal3.2.0w64/test_198_out	2020-11-02 18:51:31.349029500 -0500
@@ -0,0 +1,13 @@
+ERROR:  relation "raster_outdb_template" does not exist at character 103
+ERROR:  relation "raster_outdb_template" does not exist at character 97
+ERROR:  relation "raster_outdb_template" does not exist at character 95
+ERROR:  relation "raster_outdb_template" does not exist at character 109
+ERROR:  relation "raster_outdb_template" does not exist at character 100
+ERROR:  relation "raster_outdb_template" does not exist at character 98
+ERROR:  relation "raster_outdb_template" does not exist at character 109
+ERROR:  relation "raster_outdb_template" does not exist at character 111
+ERROR:  relation "raster_outdb_template" does not exist at character 107
+ERROR:  relation "raster_outdb_template" does not exist at character 67
+ERROR:  relation "raster_outdb_template" does not exist at character 103
+ERROR:  relation "raster_outdb_template" does not exist at character 73
+ERROR:  relation "raster_outdb_template" does not exist at character 115
-----------------------------------------------------------------------------
 ./raster/test/regress/box3d .. ok in 328 ms
 ./raster/test/regress/rt_addband .. failed (diff expected obtained: /projects/postgis/tmp/3.1.0dev_pg11_geos3.9_gdal3.2.0w64/test_200_diff)
-----------------------------------------------------------------------------
--- ./raster/test/regress/rt_addband_expected	2020-11-02 18:19:50.207692600 -0500
+++ /projects/postgis/tmp/3.1.0dev_pg11_geos3.9_gdal3.2.0w64/test_200_out	2020-11-02 18:51:33.241759100 -0500
@@ -108,17 +108,8 @@
 5|64BF|0|f||||
 6|2BUI|0|f||||
 90
-1|1|t|t
-1|2|t|t
-1|3|t|t
-2|1|t|t
-2|2|t|t
-2|3|t|t
-3|1|f|
-3|2|t|t
-4|1|t|t
-4|2|f|
-NOTICE:  Attempting to get pixel value with out of range raster coordinates: (99, 99)
-255
-90
-255
+ERROR:  relation "raster_outdb_template" does not exist at character 160
+ERROR:  relation "raster_outdb_template" does not exist at character 160
+ERROR:  relation "raster_outdb_template" does not exist at character 160
+ERROR:  relation "raster_outdb_template" does not exist at character 160
+ERROR:  relation "raster_outdb_template" does not exist at character 74
-----------------------------------------------------------------------------
:
 ./raster/test/regress/rt_setbandpath .. failed (diff expected obtained: /projects/postgis/tmp/3.1.0dev_pg11_geos3.9_gdal3.2.0w64/test_235_diff)
-----------------------------------------------------------------------------
--- ./raster/test/regress/rt_setbandpath_expected	2020-11-02 18:19:50.736054500 -0500
+++ /projects/postgis/tmp/3.1.0dev_pg11_geos3.9_gdal3.2.0w64/test_235_out	2020-11-02 18:52:28.773544300 -0500
@@ -1,6 +1 @@
-1|1|t|t|1
-1|2|t|t|2
-1|3|t|t|3
-2|1|t|t|2
-2|2|t|t|2
-2|3|t|t|3
+ERROR:  relation "raster_outdb_template" does not exist at character 177
-----------------------------------------------------------------------------
 ./raster/test/regress/rt_utility .. failed (diff expected obtained: /projects/postgis/tmp/3.1.0dev_pg11_geos3.9_gdal3.2.0w64/test_236_diff)
-----------------------------------------------------------------------------
--- ./raster/test/regress/rt_utility_expected	2020-11-02 18:19:50.794653600 -0500
+++ /projects/postgis/tmp/3.1.0dev_pg11_geos3.9_gdal3.2.0w64/test_236_out	2020-11-02 18:52:29.732605400 -0500
@@ -37,24 +37,8 @@
     band 3 of pixtype 16BSI is in-db with no NODATA value
 Skewed raster of 10x10 pixels has 1 band and extent of BOX(0 -10,10 0.0001)
     band 1 of pixtype 8BUI is in-db with NODATA value of 0
-1|Raster of 90x50 pixels has 3 bands and extent of BOX(0 -50,90 0)
-    band 1 of pixtype 8BUI is out-db with no NODATA value
-    band 2 of pixtype 8BUI is out-db with no NODATA value
-    band 3 of pixtype 8BUI is out-db with no NODATA value
-2|Raster of 90x50 pixels has 3 bands and extent of BOX(0 -50,90 0)
-    band 1 of pixtype 8BUI is out-db with no NODATA value
-    band 2 of pixtype 8BUI is out-db with no NODATA value
-    band 3 of pixtype 8BUI is out-db with no NODATA value
-3|Raster of 90x50 pixels has 2 bands and extent of BOX(0 -50,90 0)
-    band 1 of pixtype 8BUI is in-db with NODATA value of 0
-    band 2 of pixtype 8BUI is out-db with no NODATA value
-4|Raster of 90x50 pixels has 2 bands and extent of BOX(0 -50,90 0)
-    band 1 of pixtype 8BUI is out-db with NODATA value of 255
-    band 2 of pixtype 8BUI is in-db with NODATA value of 0
+ERROR:  relation "raster_outdb_template" does not exist at character 37
 ms1|64
 NOTICE:  Could not find raster band of index 1 when getting band path. Returning NULL
 bandpath1|
-bandpath2|testraster.tif
-bandpath2|testraster.tif
-bandpath2|
-bandpath2|testraster.tif
+ERROR:  relation "raster_outdb_template" does not exist at character 55
-----------------------------------------------------------------------------
:
 ./raster/test/regress/loader/BasicOutDB . failed (Failed evaluating ./raster/test/regress/loader/BasicOutDB-pre.pl: ./raster/test/regress/loader/BasicOutDB: No such file or directory at ./raster/test/regress/loader/BasicOutDB-pre.pl line 13.)

Change History (4)

comment:1 by strk, 4 years ago

This seems to be the culprit:

./raster/test/regress/load_outdb . failed (Failed evaluating ./raster/test/regress/load_outdb-pre.pl: ./raster/test/regress/load_outdb: No such file or directory at ./raster/test/regress/load_outdb-pre.pl line 60.)

Line 60 of load_outdb-pre.pl reads:

my $PREFNAME = abs_path($TEST) . '-pre.sql';

Could it be the Perl version on winnie has an abs_path function that fails at evaluating non-existing files ? Can you try running run_test.pl manually ?

comment:2 by strk, 4 years ago

Similar issue later:

./raster/test/regress/loader/BasicOutDB: No such file or directory at ./raster/test/regress/loader/BasicOutDB-pre.pl line 13.)

comment:3 by Sandro Santilli <strk@…>, 4 years ago

In 873d3e5/git:

Do not use abs_path if not strictly needed

Hopefully fixes windows builds (winnie).
See #4781

comment:4 by robe, 4 years ago

Resolution: fixed
Status: newclosed
Note: See TracTickets for help on using tickets.