Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#4571 closed defect (fixed)

PostGIS upgrade from unpackaged tests trying to downgrade

Reported by: robe Owned by: strk
Priority: blocker Milestone: PostGIS 3.0.1
Component: build Version: 3.0.x
Keywords: Cc:

Description (last modified by robe)

I think there is something wrong with our postgres upgrade regress tests in that it's trying future versions to downgrade.

Debbie is failing on PostGIS 3.0 upgrade test with: https://debbie.postgis.net/job/PostGIS_Regress/13498/consoleFull

15:05:26 PostgreSQL 12.0 on x86_64-pc-linux-gnu, compiled by gcc (Debian 9.2.1-9) 9.2.1 20191008, 64-bit
15:05:26   Postgis 3.0.1dev - r17988 - 2019-11-06 20:01:22
15:05:26   scripts 3.0.1dev r17988
15:05:26   GEOS: 3.9.0dev-CAPI-1.14.0 
15:05:26   PROJ: 6.2.0
15:05:26 
15:05:26 Running tests
15:05:26 

15:22:17 psql:/var/lib/jenkins/workspace/pg/rel/pg12w64/share/postgresql/contrib/postgis-3.1/postgis.sql:2793: ERROR:  could not find function "postgis_lib_revision" in file "/var/lib/jenkins/workspace/pg/rel/pg12w64/lib/postgresql/postgis-3.so"
15:22:17 make: Leaving directory '/var/lib/jenkins/workspace/postgis/branches/3.0/raster/test/regress'
15:22:17 FAIL: upgrade unpackaged3.1--3.0.1dev

Why are future versions of PostGIS even in past test runs?

Change History (6)

comment:1 by robe, 4 years ago

Description: modified (diff)

comment:2 by Regina Obe <lr@…>, 4 years ago

Resolution: fixed
Status: newclosed

In 160deab/git:

Hopefully fixes #4571

comment:3 by robe, 4 years ago

Summary: PostGIS upgrade tests trying to downgradePostGIS upgrade from unpackaged tests trying to downgrade

comment:4 by Regina Obe <lr@…>, 4 years ago

In e342944/git:

Don't test newer unpackaged than version we installed. Closes #4571 for PostGIS 3.1 trunk

comment:5 by strk, 4 years ago

Regina is this not worth a NEWS entry ? (just wondering, as I'm playing with my new check_news.sh toy…

[strk@liz:/usr/src/postgis/postgis-3.0(stable-3.0)] ../postgis/utils/check_news.sh --ticket-refs .  
PASS: NEWS file entries are in good order
INFO: Checking ticket refs in commits since tag '3.0.0'
FAIL: Ticket #4571 MISSING from NEWS
FAIL: Ticket #4570 MISSING from NEWS
FAIL: Ticket #1003 MISSING from NEWS

comment:6 by robe, 4 years ago

Not newsworthy as it would only show up in our regression tests. So not a public facing thing.

Note: See TracTickets for help on using tickets.