Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#4202 closed defect (fixed)

Topology extension upgrade from 2.1.9 to 3.0.0dev fails

Reported by: strk Owned by: strk
Priority: medium Milestone: PostGIS 2.2.8
Component: topology Version: 2.2.x
Keywords: Cc:

Description

Run:

regress/run_test.pl -v --extension \
  --topology --upgrade-path 2.1.9--3.0.0dev \
  topology/test/regress/st_simplify.sql

I get:

ERROR:  cannot drop schema topology because other objects depend on it
DETAIL:  function _st_remedgecheck(character varying,integer,integer,integer,integer) depends on schema topology

Change History (7)

comment:1 by strk, 6 years ago

The problem seems related to #2138 as the uninstall code in run_test.pl goes:

    if ( $OPT_WITH_TOPO )
    {   
        # NOTE: "manually" dropping topology schema as EXTENSION does not
        #       take care of that itself, see
        #       http://trac.osgeo.org/postgis/ticket/2138
        $cmd = "psql $psql_opts -c \"DROP EXTENSION postgis_topology; DROP SCHEMA topology;\" $DB >> $REGRESS_LOG 2>&1";
        $rv = system($cmd);
          $ok = 0 if $rv;
    }

I guess the DROP SCHEMA topology is checked _before_ the DROP EXTENSION takes effect (within same transaction) thus the problem.

comment:2 by strk, 6 years ago

Component: build/upgrade/installtopology
Milestone: PostGIS 3.0.0PostGIS 2.2.8
Version: trunk2.2.x

More simply: the _st_remEdgeCheck function was removed in 2.2.0 and never marked as such in the _drop_* scripts.

comment:3 by strk, 6 years ago

In 16900:

[topology] properly drop removed internal functions on upgrade

References #4202 in trunk

comment:4 by strk, 6 years ago

In 16901:

[topology] properly drop removed internal functions on upgrade

References #4202 in 2.5 branch

comment:5 by strk, 6 years ago

In 16902:

[topology] properly drop removed internal functions on upgrade

References #4202 in 2.3 branch

comment:6 by strk, 6 years ago

Resolution: fixed
Status: newclosed

In 16905:

[topology] properly drop removed internal functions on upgrade

Closes #4202 in 2.2 branch

comment:7 by strk, 6 years ago

In 16906:

[topology] properly drop removed internal functions on upgrade

References #4202 in 2.4 branch

Note: See TracTickets for help on using tickets.