winnie - sfcgal change to trigger PostGIS build, and also patch sfcgal-conifg

[robe]

As noted in #3367, winnie's 9.4 w32 (i'll check if its the same iwth w64), started failing, unable to compile in Cunit

at r14376

with error:

*** Warning: Linking the executable cu_tester against the loadable module
*** libSFCGAL.dll is not portable!
libtool: link: i686-w64-mingw32-gcc -g -O2 -Wall -Wmissing-prototypes -I/projects/geos/rel-3.5.0w32gcc481/include -I/projects/proj/rel-4.9.1w32gcc481/include -I/projects/postgresql/rel/pg9.4w32gcc481/include -I/projects/rel-libiconv-1.13.1w32gcc481/include -I.. -Ie:/jenkins/CGAL/rel-sfcgal-1.2w32gcc481/include -DHAVE_SFCGAL -o .libs/cu_tester cu_algorithm.o cu_bytebuffer.o cu_buildarea.o cu_clean.o cu_print.o cu_misc.o cu_ptarray.o cu_geodetic.o cu_geos.o cu_geos_cluster.o cu_tree.o cu_measures.o cu_effectivearea.o cu_node.o cu_clip_by_rect.o cu_libgeom.o cu_split.o cu_stringbuffer.o cu_triangulate.o cu_homogenize.o cu_force_sfs.o cu_out_twkb.o cu_out_wkt.o cu_out_wkb.o cu_out_gml.o cu_out_kml.o cu_out_geojson.o cu_out_svg.o cu_out_encoded_polyline.o cu_surface.o cu_out_x3d.o cu_in_geojson.o cu_in_twkb.o cu_in_wkb.o cu_in_wkt.o cu_in_encoded_polyline.o cu_varint.o cu_unionfind.o cu_tester.o cu_sfcgal.o  ../.libs/liblwgeom.a -L/projects/postgresql/rel/pg9.4w32gcc481/lib -L/projects/gdal/rel-2.0.1w32gcc481/lib -L/projects/rel-libiconv-1.13.1w32gcc481/lib -L/projects/geos/rel-3.5.0w32gcc481/lib -L/projects/proj/rel-4.9.1w32gcc481/lib -L/projects/json-c/rel-0.12w32gcc481/lib -Le:/jenkins/CGAL/rel-sfcgal-1.2w32gcc481/lib /projects/proj/rel-4.9.1w32gcc481/lib/libproj.dll.a -lpthread /projects/json-c/rel-0.12w32gcc481/lib/libjson-c.a -lgeos_c /mingw/i686-w64-mingw32/lib/libcunit.a -L/sources/CUnit-2.1-2/CUnit/Sources e:/jenkins/CGAL/rel-sfcgal-1.2w32gcc481/lib/libSFCGAL.dll -L/projects/proj/rel-4.9.1w32gcc481/lib -L/projects/json-c/rel-0.12w32gcc481/lib -Le:/jenkins/CGAL/rel-sfcgal-1.2w32gcc481/lib
Makefile:82: recipe for target `check' failed
make[2]: *** [check] Error 53
make[2]: Leaving directory `/projects/postgis/branches/2.2/liblwgeom/cunit'
Makefile:186: recipe for target `check' failed
make[1]: *** [check] Error 2
make[1]: Leaving directory `/projects/postgis/branches/2.2/liblwgeom'
GNUmakefile:16: recipe for target `check' failed
make: *** [check] Error 1

The 2.3 build works fine though, so could very well be something I changed between Nov 7th and Nov 10th and not related to this.

Given that doing the same 9.4 32-bit run on my pc which is more or less setup the same as winnie, suggests it's just a configuration issue.

[robe]

okay turns out to be stupid me, no surprise there

I had set it to use SFCGAL 1.2 branch, but the sfcgal-config generated by sfcgal generates this prefix:

prefix=e:/jenkins/CGAL/rel-sfcgal-1.2w64gcc48

which needs to be changed to

prefix=/projects/CGAL/rel-sfcgal-1.2w64gcc48

to work right.

There was an SFCGAL change since last compile of PostGIS which triggers this issue.

Anyrate, I have to put in logic in my sfcgal build to fix the generated sfcgal-config script.

I'll close this out once I have that in place.

[robe]

I guess I need to also make SFCGAL build trigger at least PostGIS 2.2 build so I don't blame the wrong commit next time.

[robe]

(In [14383]) references #3369 patch sfcgal path to use linux/unix style path instead of windows drive letter path

[robe]

(In [14384]) references #3369 revert accidental path change

[robe]

(In [14385]) references #3369 wrong SED command on last try this

[robe]

okay think that did it and also added to run PostGIS 2.2 build after sfcgal build.