Opened 5 years ago

Closed 5 years ago

#3022 closed task (fixed)

ValidateTopology error description order should match order of ids

Reported by: robe Owned by: strk
Priority: medium Milestone: PostGIS 2.2.0
Component: topology Version: master
Keywords: Cc:

Description

Regarding this:

edge crosses node | node_id | edge_id # NOTE: should this be swapped?

After closer inspection, I feel that yes we should swap and we should consider the order of topo element ids not matching the order of the error note a bug. Reason being is that most people will assume that and will probbly never look at the docs to see its swapped.

Change History (5)

comment:1 Changed 5 years ago by strk

Swapped in trunk with r13205 -- should it be NOTE'd in the documentation that they were swapped before ? I'll wait for an answer (or tweak) before backporting to 2.1 and 2.0 branches...

comment:2 Changed 5 years ago by robe

Yes it should be noted in docs that they were swapped before.

I would just put a

CHANGED: 2.0.7 .. id, id1 for error edge crosses node were changed from node_id, edge_id to edge_id, node_id to be consistent with the error description.

comment:3 Changed 5 years ago by strk

But CHANGED 2.0.7 could make you think 2.1.0 had the new behavior already. Should we then specify a first patch version for every branch ? Or just forget about backporting the fix to the 2.0 branch ? It's not a critical fix after all. Actually is a real change in behavior. Maybe better to just change in 2.2.0

comment:4 Changed 5 years ago by robe

good point. I would say forget about back-porting.

comment:5 Changed 5 years ago by strk

Milestone: PostGIS 2.0.7PostGIS 2.2.0
Resolution: fixed
Status: newclosed
Type: defecttask
Version: 2.0.xtrunk

Ok, dealt with it only for 2.2.0 then, in trunk as r13206

Note: See TracTickets for help on using tickets.