Opened 8 years ago

Closed 8 years ago

#3021 closed enhancement (fixed)

Document possible errors from ValidateTopology

Reported by: strk Owned by: robe
Priority: medium Milestone: PostGIS 2.1.6
Component: documentation Version: master
Keywords: Cc:

Description

The manual page for ValidateTopology should contain a table with possible error messages and the meaning of "id1" and "id2" in those cases.

Here's the current set:

coincident nodes | node_id | node_id
edge crosses node | node_id | edge_id # NOTE: should this be swapped?
invalid edge | edge_id | null
edge not simple | edge_id | null
edge crosses edge | edge_id | edge_id
edge start node geometry mis-match | edge_id | node_id
edge end node geometry mis-match | edge_id | node_id
face without edges | face_id | null
face has no rings | face_id | null
face overlaps face | face_id | face_id
face within face | inner face_id | outer face_id

Change History (6)

comment:1 by robe, 8 years ago

Made the change to trunk at r13201. As seen here: http://postgis.net/docs/manual-dev/ValidateTopology.html

You have this slated for 2.2. Any reason I can't backport the doco changes to 2.1 (or did you add more error types? )

comment:2 by strk, 8 years ago

Milestone: PostGIS 2.2.0PostGIS 2.1.6

It is ok to backport. As you're at it, the Availability field could be set to 1.0.0 (I checked, 1.0.0 did have this function in the topology.sql file, didn't bother checking older ones)

comment:3 by robe, 8 years ago

Okay put in version 1.0.0 at r13202 and backported at r13203

I see what you mean about the edge crosses node. To be consistent with the others edge should by id1 and node should be id2.

Since we never documented the order before, I'm guessing people assumed the order followed the ordering of the description so okay to change and just treat the old as a bug. We can put a notice that order changed in 2.1.6 to be consistent with error description.

comment:4 by robe, 8 years ago

r13203 is version change and r13204 is backport

comment:5 by strk, 8 years ago

If you're strong about the "thread edge_id/node_id as a bug" argument, could you please file a ticket ? If it's a bug it'll need to be patched in 2.0, 2.1 and 2.2 …

comment:6 by robe, 8 years ago

Resolution: fixed
Status: newclosed

okay going to close this out and start a new one.

Note: See TracTickets for help on using tickets.