Opened 5 years ago

Closed 10 months ago

#2909 closed defect (fixed)

bad dependency expression results in rule firing on subsequent make, and make install

Reported by: gdt Owned by: strk
Priority: low Milestone: PostGIS 2.2.8
Component: build/upgrade/install Version: 2.1.x
Keywords: Cc: gdt


In several makefiles, e.g extensions/postgis/, there is a rule:

sql_minor_upgrade: sql_bits/extension_upgrade_minor.sql
          cat $< > sql/$(EXTENSION)--$$OLD_VERSION--$(EXTVERSION).sql; \

which results in the following being executed on a subsequent make, and on make install, because no file sql_minor_upgrade is created.

---- Making all in postgis
gmake[3]: Entering directory '/u0/n0/gdt/NetBSD-current/pkgsrc/wip/postgresql-postgis2/work/postgis-2.1.3/extensions/postgis'
for OLD_VERSION in 2.0.0 2.0.1 2.0.2 2.0.3 2.0.4 2.0.5; do \
          cat sql_bits/extension_upgrade_minor.sql > sql/postgis--$OLD_VERSION--2.1.3.sql; \
for OLD_VERSION in 2.1.0rc1 2.1.0rc2 2.1.0rc3 2.1.0 2.1.1 2.1.2; do \
          cat sql_bits/extension_upgrade_patch.sql > sql/postgis--$OLD_VERSION--2.1.3.sql; \
gmake[3]: Leaving directory '/u0/n0/gdt/NetBSD-current/pkgsrc/wip/postgresql-postgis2/work/postgis-2.1.3/extensions/postgis'

To fix, probably the phony target should be created by the rule body, so that it doesn't get reexecuted.

Attachments (1) (661 bytes) - added by gdt 5 years ago.
patch for discussion (works, but only fixes one subdir)

Download all attachments as: .zip

Change History (10)

comment:1 Changed 5 years ago by gdt

Version: trunk2.1.x

Sorry, this was observed on 2.1.3, not trunk.

Changed 5 years ago by gdt

patch for discussion (works, but only fixes one subdir)

comment:2 Changed 4 years ago by gdt

I am still seeing this in 2.1.8.

comment:3 Changed 3 years ago by dbaston

Milestone: PostGIS 2.1.9

comment:4 Changed 21 months ago by pramsey

Milestone: PostGIS 2.1.9PostGIS 2.2.6

comment:5 Changed 20 months ago by robe

Cc: gdt added

gdt is this still an issue for you in 2.4? I don't think I've every run into issue.

comment:6 Changed 20 months ago by pramsey

Milestone: PostGIS 2.2.6PostGIS 2.2.7

comment:7 Changed 15 months ago by robe

Is this still an issue? anyway pushing to 2.2.8

comment:8 Changed 15 months ago by robe

Milestone: PostGIS 2.2.7PostGIS 2.2.8

comment:9 Changed 10 months ago by gdt

Resolution: fixed
Status: newclosed

This is fixed in 2.5.0rc1, so I'm just closing it to clean up, without figuring out where it was fixed along the way.

Note: See TracTickets for help on using tickets.