Opened 5 years ago

Closed 4 years ago

#2877 closed enhancement (fixed)

Revise configure to build make scripts for address_standardizer extension

Reported by: robe Owned by: robe
Priority: high Milestone: PostGIS 2.2.0
Component: pagc_address_parser Version: master
Keywords: Cc:

Description

Address_Standardizer should inherit postgis versioning like the other extensions and scripts built accordingly.

It should also be automatically built if all prerequisites are satisfied.

Change History (7)

comment:1 Changed 5 years ago by robe

Owner: changed from woobri to robe

comment:2 Changed 5 years ago by robe

Started at r12870 next will be to have it add path to pcre if one is passed in.

comment:3 Changed 5 years ago by robe

Summary: Revise configure to build make scripts for address_standardizerRevise configure to build make scripts for address_standardizer extension

comment:4 Changed 5 years ago by robe

I am almost done with this at r13044. The way it is set if it detects PCRE and no --without-address-standardizer, it will build the address-standardizer extension.

It will also build if you pass in --with-pcre-dir=/path/to/pcre

Just have to update the documentation and fix the perl Regexp requirement. I wasn't able to test the Perl RegexP requirement on my machine since I have that installed.

But luckily Debbie doesn't and is screaming :). She was fine before I installed pcre since it was correctly disabling the address_standardizer extension

apt-get libpcre3 libpcre3-dev

Now got to fix the

Can't locate Regexp/Assemble.pm in @INC (@INC contains: /etc/perl /usr/local/lib/perl/5.10.1 /usr/local/share/perl/5.10.1 /usr/lib/perl5 /usr/share/perl5 /usr/lib/perl/5.10 /usr/share/perl/5.10 /usr/local/lib/site_perl .) at mk-city-regex.pl line 4.
BEGIN failed--compilation aborted at mk-city-regex.pl line 4.
make[2]: *** [mk-city-regex] Error 2
make[2]: Leaving directory `/var/lib/jenkins/workspace/postgis/branches/2.2/extensions/address_standardizer'
make[1]: *** [all] Error 1
make[1]: Leaving directory `/var/lib/jenkins/workspace/postgis/branches/2.2/extensions'
make: *** [all] Error 1

by disabling those compiles

comment:5 Changed 5 years ago by robe

debbie seems happy at r13048. I'm not happy with my change though.

I ended up remarking out the below in addition to making sure they are not cleaned up during clean

parseaddress-stcities.h: mk-city-regex
	./mk-city-regex > parseaddress-stcities.h

parseaddress-regex.h: mk-st-regexp
	./mk-st-regexp > parseaddress-regex.h

I'm not sure why remarking out is necessary. I thought since its distributed it wouldn't try to build if it saw they were present.

comment:6 Changed 4 years ago by robe

This is more or less done for main extenion, but I'm working on packaging the address data as an extension. The tricky part is I've got to destroy the existing files and replace with insert since the original uses COPY commands which won't work in an extension install.

I was thinking of fiddling with the perl script, but decided its probably just as easy to directly edit a bunch of inserts than fiddle with screwing up the perl conversion with my limited skill in perl.

comment:7 Changed 4 years ago by robe

Resolution: fixed
Status: newclosed

This is done too.

Note: See TracTickets for help on using tickets.