Debbie coughing up blood on upgrade (postgis_21_minor.sql)

[robe]

I traced the issue down to this:

psql:/var/lib/jenkins/workspace/postgis/branches/2.2/regress/00-regress-install/share/contrib/postgis/postgis_upgrade_21_minor.sql:2156: ERROR:  syntax error at or near "("
LINE 1: ...ATE IF EXISTS st_astwkb_agg(geometry,int,int,text)(unknown);

Nicklas — I'll add you to the notification list. I don't think you are on it.

winnie is complaining too but her issue seems different and may have nothing to do with this.

[robe]

forgot to mention the issue is at r11736 though that file I thought was autogenerated so it might be a bug in the postgis upgrade generator script since the full install installs fine.

So we might have to pass off to strk when he comes back if we can't isolate the issue.

[nicklas]

I will take a look in a few hours.

[nicklas]

I suspect that this is about that I have used the "new" syntax for creating aggregates. ​http://www.postgresql.org/docs/9.1/static/sql-createaggregate.html and the other PostGIS vector aggregates seems to use the old syntax.

Raster uses the new syntax though, but I do not manage to understand if those upgrade scripts is also auto generated or or written manually.

[nicklas]

I think r11740 fixes the problem.

But please someone review if it is a too hackish solution.

[robe]

Seems to still be failing at upgrade after you made your change. ​http://debbie.postgis.net:8080/job/PostGIS_Regress/2347/console

Upgrading PostGIS in 'postgis_reg' 
Upgrading core

Error encountered loading /var/lib/jenkins/workspace/postgis/branches/2.2/regress/00-regress-install/share/contrib/postgis/postgis_upgrade_21_minor.sql, see /var/lib/jenkins/workspace/postgis/tmp/2_2_pg9.2w64/regress_log for details

make[1]: *** [check] Error 9
make[1]: Leaving directory `/var/lib/jenkins/workspace/postgis/branches/2.2/regress'
make: *** [check] Error 1

I know originally that raster did not use the upgrade perl script. I think I had coded a sed script for it. I forget if that was changed later or if its still using the sed script I had created.

Anyway I'll take a stab at looking at this in a bit. I suspect its something really stupid.

[robe]

more info from regress_log

psql:/var/lib/jenkins/workspace/postgis/branches/2.2/regress/00-regress-install/share/contrib/postgis/postgis_upgrade_21_minor.sql:2079: ERROR:  syntax error at or near ";"
LINE 1: DROP AGGREGATE IF EXISTS ST_Extent;

[nicklas]

Ah,of course. If no basetype and the old syntax there will be a missing "()". I think I know how to solve it. Will take a look when kids are in bed.

[nicklas]

Forget my last comment. You always need a basetype if using the old syntax.

But I think it is fixed with r11741

It was about my non existent Pearl knowledge.

[robe]

yes I see green lights now. Thanks and welcome back. Hope you stick around for a while

[nicklas]

Thanks

I hope to be able to put more time in it.

About Debbie and Winnie, I had a nice mail from Debbie telling me she was feeling better, but Winnie just seems to ignore me. Did you give here my address too?

Should I have had a mail when she was building successfully again?

[robe]

winnie tends to be grumpy a lotso I don't have her send email since she's often just in a bad mood and nothing wrong with the change. I just check her every once in a while to make sure it's nothing chronic.