Opened 11 years ago
Closed 9 years ago
#2303 closed defect (fixed)
shp2pgsql-gui double includes postgis_config.h and parts of liblwgeom
| Reported by: | robe | Owned by: | mcayland |
|---|---|---|---|
| Priority: | medium | Milestone: | PostGIS 2.2.0 |
| Component: | utils/loader-dumper | Version: | master |
| Keywords: | Cc: |
Description
In trying to troubleshoot why I always have random problems with shp2pgsql-gui and not with the commandline one. I noticed it has double includes (or at least I think it does).
It has an include at top for ../postgis_config.h
Then it includes shp2pgsql-core.h and pgsql2shp-core.h of which shp2pgsql-core.h also includes postgis_config.h
I'm also wondering why we need liblwgeom.h (when note says for lw_vasprintf).
When shp2pgsql-core.h already explicitly includes
#include "../liblwgeom/stringbuffer.h"
which contains the vasprintf thingy.
Change History (2)
comment:1 by , 11 years ago
| Milestone: | PostGIS 2.0.4 → PostGIS 2.2.0 |
|---|
comment:2 by , 9 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
Note:
See TracTickets
for help on using tickets.
r14176