Opened 11 years ago
Closed 11 years ago
#2275 closed defect (fixed)
configure is not backwad compatible
Reported by: | robe | Owned by: | pramsey |
---|---|---|---|
Priority: | blocker | Milestone: | PostGIS 2.1.0 |
Component: | build | Version: | master |
Keywords: | Cc: |
Description
Just noticed Debbie can't build doxygen anymore after
error is:
configure: error: could not find pg_config within the current path. You may need to try re-running configure with a --with-pg_config parameter.
I put in a distclean and that didn't help. Doesn't seem to affect regress so maybe something needs changing in doxygen logic?
Change History (9)
comment:1 by , 11 years ago
comment:2 by , 11 years ago
Summary: | doxygen building is broken → doxygen and html/pdf document building is broken |
---|
To add also broke the doc building job.
http://debbie.postgis.net:8080/job/PostGIS_2.1_docs/
checking for iconvctl... no checking for libiconvctl... no checking for pg_config... no configure: error: could not find pg_config within the current path. You may need to try re-running configure with a --with-pg_config parameter.
comment:3 by , 11 years ago
Owner: | changed from | to
---|
Was it —with-pgconfig before ? We don't want to break backward compatibility. But above that, we don't want underscores in configure switches…
comment:4 by , 11 years ago
comparing my configures. This is what the doc one looks like
CPPFLAGS="-I${PGPATH}/include" \ LDFLAGS="-L${PGPATH}/lib" ./configure \ --with-pgconfig=${PGPATH}/bin/pg_config \ --with-geosconfig=${PROJECTS}/geos/rel-${GEOS_VER}w${OS_BUILD}/bin/geos-config \ --without-raster
I just noticed somebody must have changed the tar one because I have this line I don't remember putting in the source tar and regress builds (perhaps dustymugs because I know the rest of you are too chicken to change anything ):
if [ `expr "${POSTGIS_TAG}" : "trunk"` -gt 0 ]; then PGCONFIG="--with-pg_config=${PGPATH}/bin/pg_config" else PGCONFIG="--with-pgconfig=${PGPATH}/bin/pg_config" fi
However the regress one looks like this:
./configure \ --with-pgconfig=${PROJECTS}/pg/rel/pg${PG_VER}w${OS_BUILD}/bin/pg_config \ --with-geosconfig=${PROJECTS}/geos/rel-${GEOS_VER}w${OS_BUILD}/bin/geos-config \ --with-gdalconfig=${PROJECTS}/gdal/rel-${GDAL_VER}w${OS_BUILD}/bin/gdal-config --without-topology
The without-topology I had put in because I was trying to debug our configure things and it was acting oddly if I did a make distclean and it was in there.
I guess we should probably move these scripts to subversion so we can better monitor these changes.
The winnie ones haven't changed much though (since those are in subversion. I just recently added Bborie's conditional make distclean). I'll retest because the last one I hand tested after my make distclean change was w32 which always fails because of some weirdness on winnie with the with-gui test.
http://trac.osgeo.org/postgis/browser/buildbots/windows/mingw64/scripts/regress_postgis.sh and has
--with-pgconfig=${PGPATH}/bin/pg_config
comment:5 by , 11 years ago
aha I think I see why both Debbie and Winnie regress still work after this change.
I am alway in the habit of adding PGPATH to to the PATH variable, so Debbie's regress has a line like this:
PATH=${PATH}:${PGPATH}/bin
So I guess even though the —with-pgconfig is no longer legal, it didn't really need it. I don't have that for the docs though so that is relying on the name.
So yah I think for a lot of folks, this is going to be a breaking change in there configure logic. Mostly package maintainers.
comment:6 by , 11 years ago
Summary: | doxygen and html/pdf document building is broken → configure is not backwad compatible |
---|
comment:7 by , 11 years ago
Also note our documentation if we wish to break backward compatibility needs to be changed:
http://postgis.net/docs/manual-dev/postgis_installation.html#installation_configuration
comment:8 by , 11 years ago
Note from mark_wanner
markus_wanner: A little background: part of why I requested to change PGCONFIG to PG_CONFIG was that other PGXN tools use the later env var. And I tried to build postgis with setting that - and failed. I don't care that much about the --with-*config argument, just changed it to match.
I vote for changing the .configure back to —with-pgconfig
so its consistent with —with-gdalconfig and friends.
oops sorry reference wrong changeset because they were mashed together.
It's r11301