Opened 11 years ago

Closed 11 years ago

#2274 closed defect (fixed)

pagc doesn't compile with 9.3 development

Reported by: robe Owned by: robe
Priority: medium Milestone: PostGIS 2.1.0
Component: pagc_address_parser Version: master
Keywords: Cc: swoodbridge, woodbri

Description

This isn't critical yet, but when EnterpriseDb starts releasing their 9.3 betas and rc builds, I plan to also have winnie start building PostGIS builds for 9.3. I suspect this issue might be just a minor version number thing but PG versions are never fully formed until release and at that point its kind of late to find out there are issues.

Here is error I get trying to compile against 9.3

/bin/perl.exe mk-sql.pl 'PostgreSQL 9.3devel' address_standardizer--1.0.sql.in >
 address_standardizer--1.0.sql
Failed to parse 'PostgreSQL 9.3devel' as /^PostgreSQL (\d+)\.(\d+)\b/
/
make: *** [address_standardizer--1.0.sql] Error 255
make: *** Deleting file `address_standardizer--1.0.sql'
/bin/perl.exe mk-sql.pl 'PostgreSQL 9.3devel' address_standardizer--1.0.sql.in >
 address_standardizer--1.0.sql
Failed to parse 'PostgreSQL 9.3devel' as /^PostgreSQL (\d+)\.(\d+)\b/
/
make: *** [address_standardizer--1.0.sql] Error 255
make: *** Deleting file `address_standardizer--1.0.sql'

PostgreSQL 9.3 is about to hit beta 1.

Change History (15)

comment:1 by robe, 11 years ago

Milestone: PostGIS 2.1.0PostGIS 2.2.0

comment:2 by robe, 11 years ago

Cc: swoodbridge added

It would be really nice if I can get this issue fixed. I'm guessing its pretty minor.

I'd like all my windows packages for 2.1 to be the same and want to start testing this with the 9.3 betas.

comment:3 by robe, 11 years ago

I got this to install on 9.3beta2 by changing the mk-sql.pl script. Line 14 check. essentially just get rid of the \b

$ver =~ /^PostgreSQL (\d+)\.(\d+)/

comment:4 by woodbri, 11 years ago

Cc: woodbri added

Just updated the repository.

comment:5 by robe, 11 years ago

Resolution: fixed
Status: newclosed

great thanks.

comment:6 by robe, 11 years ago

Milestone: PostGIS 2.2.0PostGIS 2.1.0

comment:7 by robe, 11 years ago

Resolution: fixed
Status: closedreopened

Steve,

Did the repository location move — for some reason I thought I had pulled your latest change and verified it worked, but repulling I don't see the change and don't see it listed either (so I might have been using my patched copy). I have this:

http://pagc.svn.sourceforge.net/viewvc/pagc/branches/sew-refactor/postgresql/

As location but last change on that is 2 months ago.

comment:8 by woodbri, 11 years ago

Yes source forge has moved things around.

svn checkout svn://svn.code.sf.net/p/pagc/code/ pagc

http://sourceforge.net/p/pagc/code/360/tree/

comment:9 by robe, 11 years ago

okay I'll close this out after I retest and update the docs to new location.

comment:11 by robe, 11 years ago

Hmm this is rather annoying. There seems to be no way anymore to download just that subfolder as a compressed file without downloading the whole 6 MB project.

comment:12 by woodbri, 11 years ago

Yes, I just looked at the new site and I do not see anyway to get just the folder. I also opened a tick for this. You might want to add your input to the ticket.

https://sourceforge.net/p/forge/feature-requests/144/

comment:13 by robe, 11 years ago

That's okay for now. I just revised winnie to just pull that portion of the tree and I'll update PostGIS instructions to use:

svn co svn://svn.code.sf.net/p/pagc/code/branches/sew-refactor/postgresql

comment:14 by robe, 11 years ago

I mean

svn co svn://svn.code.sf.net/p/pagc/code/branches/sew-refactor/postgresql address_standardizer 

or some such thing.

comment:15 by robe, 11 years ago

Resolution: fixed
Status: reopenedclosed
Note: See TracTickets for help on using tickets.