Opened 9 years ago

Closed 9 years ago

#1221 closed task (fixed)

Update Java components to support SRID<=0 as unknown SRID

Reported by: pramsey Owned by: delawen
Priority: high Milestone: PostGIS 2.0.0
Component: java Version: master
Keywords: Cc:

Description

After implementation of #286, the java subcomponents remain full of unsubstituted references to -1.

Attachments (1)

jdbc.patch (41.6 KB) - added by delawen 9 years ago.

Download all attachments as: .zip

Change History (9)

comment:1 Changed 9 years ago by strk

Summary: Update Java components to support SRID=0 as unknown SRIDUpdate Java components to support SRID<=0 as unknown SRID

As per http://postgis.refractions.net/pipermail/postgis-devel/2011-October/015426.html UNKNOWN is now anything <= 0. Such check might be worth doing with a macro.

comment:2 Changed 9 years ago by strk

Owner: changed from pramsey to strk
Status: newassigned

first windows, now java... it's a weird day for me today.

comment:3 Changed 9 years ago by strk

Actually, are there any users of the java components ? There's no regression test I can see.

comment:4 Changed 9 years ago by strk

So, r8481 attempts at a blind fix. I didn't even succeed in building anything though, in that "make" said it didn't know what to do.

If anyone knows how to build anything under that dir please provide a Makefile for the rest of the world ?

comment:5 Changed 9 years ago by strk

Component: postgisJava bindings
Owner: changed from strk to delawen
Status: assignednew

Changed 9 years ago by delawen

Attachment: jdbc.patch added

comment:6 Changed 9 years ago by delawen

Resolution: fixed
Status: newclosed

This patch should be used on the jdbc folder:

$ cd jdbc $ patch -i .../jdbc.patch -p0

I also changed the way to build the jdbc from makefile to maven, which is more appropiate for java buildings (and cleaner and easier to use, although probably slower).

comment:7 Changed 9 years ago by strk

Resolution: fixed
Status: closedreopened

@delawen please don't close tickets till the patch is actually submitted. Will be closed with a comment containing a pointer to the actual revision adding the patch.

comment:8 Changed 9 years ago by strk

Resolution: fixed
Status: reopenedclosed

@delawen: I committed your patch as r8710 but please next time keep logically separated changes in separate patches (this one contained: code fixes for SRID, indenting changes, new build system)

Thanks a lot, looking forward for more cleanups in the java comonents!

Note: See TracTickets for help on using tickets.