Opened 4 years ago

Closed 4 years ago

#554 closed defect (fixed)

saga-ltr pkg creates link without icon in start menu and desktop

Reported by: andreaerdna Owned by: osgeo4w-dev@…
Priority: minor Component: Package
Version: Keywords: saga-ltr
Cc:

Description

saga-ltr pkg (2.3.2-2) postinstall batch file fails to add start menu and desktop links with properly set icons (the links are created with blank icons) because incorrect use of double quotes with nircmd command.

In etc\postinstall\saga-ltr.bat there is only one double quote after exec hide but we need to put two double quote in order to let nircmd do its job correctly.

To solve the problem, the following lines in saga-ltr.bat

if not %OSGEO4W_DESKTOP_LINKS%==0 nircmd shortcut "%OSGEO4W_ROOT%\bin\nircmd.exe" "%OSGEO4W_DESKTOP%" "SAGA GIS (2.3.2)" "exec hide "%OSGEO4W_ROOT%\bin\saga-ltr_gui.bat""" "%OSGEO4W_ROOT%\apps\saga-ltr\saga_gui.exe"
if not %OSGEO4W_MENU_LINKS%==0 nircmd shortcut "%OSGEO4W_ROOT%\bin\nircmd.exe" "%OSGEO4W_STARTMENU%" "SAGA GIS (2.3.2)" "exec hide "%OSGEO4W_ROOT%\bin\saga-ltr_gui.bat""" "%OSGEO4W_ROOT%\apps\saga-ltr\saga_gui.exe"

need to be replaced respectively with the following lines

if not %OSGEO4W_DESKTOP_LINKS%==0 nircmd shortcut "%OSGEO4W_ROOT%\bin\nircmd.exe" "%OSGEO4W_DESKTOP%" "SAGA GIS (2.3.2)" "exec hide ""%OSGEO4W_ROOT%\bin\saga-ltr_gui.bat""" "%OSGEO4W_ROOT%\apps\saga-ltr\saga_gui.exe"
if not %OSGEO4W_MENU_LINKS%==0 nircmd shortcut "%OSGEO4W_ROOT%\bin\nircmd.exe" "%OSGEO4W_STARTMENU%" "SAGA GIS (2.3.2)" "exec hide ""%OSGEO4W_ROOT%\bin\saga-ltr_gui.bat""" "%OSGEO4W_ROOT%\apps\saga-ltr\saga_gui.exe"

or (using nircmd special string sequence ~q) with

if not %OSGEO4W_DESKTOP_LINKS%==0 nircmd shortcut "%OSGEO4W_ROOT%\bin\nircmd.exe" "%OSGEO4W_DESKTOP%" "SAGA GIS (2.3.2)" "exec hide ~q%OSGEO4W_ROOT%\bin\saga-ltr_gui.bat~q" "%OSGEO4W_ROOT%\apps\saga-ltr\saga_gui.exe"
if not %OSGEO4W_MENU_LINKS%==0 nircmd shortcut "%OSGEO4W_ROOT%\bin\nircmd.exe" "%OSGEO4W_STARTMENU%" "SAGA GIS (2.3.2)" "exec hide ~q%OSGEO4W_ROOT%\bin\saga-ltr_gui.bat~q" "%OSGEO4W_ROOT%\apps\saga-ltr\saga_gui.exe"

Change History (1)

comment:1 Changed 4 years ago by jef

Resolution: fixed
Status: newclosed

Fixed in saga-ltr 2.3.2-3. Thanks.

Note: See TracTickets for help on using tickets.