Setup shortcut doesn't work after update

[Mike Taves]

After updating setup from version 1.0.3-4 to 1.0.3-6 and restarting the computer, the "Setup" shortcut (in Start > OSGeo4W) raises the error dialog (attached):

osgeo4w-setup-work.exe

Windows cannot find 'osgeo4w-setup.work.exe'. Make sure you typed the name correctly, and then try again. To search for a file, click the Start button, and then click Search.

[OK]

Inspecting the properties for this shortcut shows that it references C:\gnu\OSGeo4W\bin\setup.bat which is a UNIX (not DOS line-ending) file:

@copy "%OSGEO4W_ROOT%\bin\osgeo4w-setup.exe" "%OSGEO4W_ROOT%\bin\osgeo4w-setup-work.exe"
@start osgeo4w-setup-work.exe %*

This is likely related to #45.

[warmerdam]

The file is unix text format, but this does not seem to be a problem for cmd.exe.

The setup.bat works fine from the OSGeo4W shell window, but not from the program files menu, apparently because the OSGeo4W bin directory isn't in the path in that context. I will upgrade the setup.bat to use a full path, instead of making path assumptions so it will work from the start menu.

[warmerdam]

I have fixed this problem, and the upgraded package is now online.

I also fixed it so the start menu entry for setup has an icon file, and modified the setup.bat and setup-test.bat files so they insert the path for OSGeo4W root at install time so they work properly outside the OSGeo4W environment.

It took me three repackagings to get this all working. :-)