Opened 8 months ago

Last modified 5 months ago

#2980 reopened task

Change default committer name and email on weblate

Reported by: robe Owned by: sac@…
Priority: normal Milestone: Sysadmin Contract 2024-I
Component: SysAdmin Keywords:
Cc:

Description

Right now whenever a commit is done on weblate it shows committed by weblate and links users to the weblate account (if on github).

This should be changed to osgeoweblate https://github.com/osgeoweblate and the email address I had setup for it so it properly links to the osgeoweblate account on github.

Looks like the way to fix this is to setup:

DEFAULT_COMMITER_EMAIL and DEFAULT_COMMITER_NAME as mentioned here:

https://github.com/WeblateOrg/weblate/commit/3c784ca12eb28b436f3902943f4cc4747c939f8c

I'm going to do that shortly and then monitor for commits to confirm it does change

Attachments (1)

weblate-author.png (30.6 KB ) - added by robe 8 months ago.
weblate-author

Download all attachments as: .zip

Change History (10)

comment:1 by neteler, 8 months ago

Would you mind to explain how the mechanism works?

I see a badly outdated fork here, e.g.: https://github.com/osgeoweblate/grass

What would be the advantage to point to the osgeoweblate forks?

comment:2 by robe, 8 months ago

Neteler,

Hmm I guess this isn't detailed here - https://wiki.osgeo.org/wiki/SAC:Weblate I apologize. I'll try to flesh that out a bit.

What I am talking about here, is how the commits credits shows on github. It doesn't change the process. Below the commits would show "weblate" even though it was "osgeoweblate" because it has noreply@… as the email address. and if people would click on the link, it would take them to github/osgeoweblate instead of github.com/osgeoweblate as you can see in workshop contributors - https://github.com/postgis/postgis-workshops/graphs/contributors and the combined would do the same - https://github.com/postgis/postgis-workshops/commit/25f3aab715ff75aba7b4d353de418205f9ad837f (authored by real author, committed by weblate).

So this change is mostly cosmetic and to get rid of confusion, and doesn't affect the flow (or at least shouldn't).

Now to you question about staleness

It looks like grass is setup right - using Github Pull Request mode, but I am seeing this notice

"The repository is outdated. You might not get expected results until you update it."

So yours seems to be a separate issue which I'll ticket as a separate

But so I remember to update wiki

So here is the process.

There are two approaches you can go with whichever makes you feel most comfortable

  1. You can specify in weblate, you want just git. If you go with that you have to

a) Give osgeoweblate commit access to your repo (with option of allowing commit or waiting for someone to manually push) - this is the option that postgis core project uses https://git.osgeo.org/gitea/postgis/postgis/commit/b74322912e5321e6df5bcbe0457cb40e8117bbdd (we don't bother with pull requests, just let it flow thru and if it breaks something we handle it after it has been dropped) or

b) Manually download and push the commits yourself

Option 2

  1. You specify Github Pull mode (on your base component, the component that all your other components were copied from):

(this is what https://github.com/postgis/postgis-workshops uses and pgrouting and osgeolive I think) https://weblate.osgeo.org/settings/grass-gis/grasslibs/#vcs and grass is doing (I think you should be able to see that page with your ldap account), note there we have:

Version control system: Github pull request

When you choose Github pull request, it uses the github account osgeoweblate, I had set up for this purpose. This account acts like a person, pulling in weblates changes and then creating a pull request against your repo.

I should add regardless the option you choose, there is a "Component discovery" plugin you should install on the first component you set up. This allows weblate to auto-generate new components based on the pattern of your first component and I think it has a checkbox to also remove no longer present components.

That last bit might be what grass is missing. Anyway let me put in a separate ticket for grass issue.

PostGIS workshop which uses the pull request model:

Here is how it works

comment:3 by robe, 8 months ago

Resolution: fixed
Status: newclosed

I'm going to close this one out since it's done. I'll reopen if it still looks to be an issue.

comment:4 by robe, 8 months ago

Resolution: fixed
Status: closedreopened

I don't think this is working.

I just merged a pull request and is still showing weblate as the secondary author and pointing at the github.com/weblate org

https://github.com/postgis/postgis-workshops/commit/14e631655cda27d38b304f629827814842aaa260

Last edited 8 months ago by robe (previous) (diff)

comment:5 by cvvergara, 8 months ago

I dont see it pointing to github.com/weblate org

by robe, 8 months ago

Attachment: weblate-author.png added

weblate-author

comment:6 by robe, 8 months ago

If you look at the two users on that commit above. One of them is https://github.com/yellow-affrc (who is the Japanese translator) and the other is https://github.com/weblate

it's very subtle. You have to mouse over to see it and click on the hyperlink

weblate-author

in reply to:  2 ; comment:7 by neteler, 8 months ago

Robe,

Replying to robe:

Neteler,

Hmm I guess this isn't detailed here - https://wiki.osgeo.org/wiki/SAC:Weblate I apologize. I'll try to flesh that out a bit.

Do you see a chance to detail it a bit more? It is unclear what the roles are and how troubleshooting works. Also, that a mirror GitHub repo exists etc. Sorry for bothering, but some explanations on the Wiki page may reduce the actual confusion.

in reply to:  7 comment:8 by robe, 7 months ago

Replying to neteler:

Robe,

Replying to robe:

Neteler,

Hmm I guess this isn't detailed here - https://wiki.osgeo.org/wiki/SAC:Weblate I apologize. I'll try to flesh that out a bit.

Do you see a chance to detail it a bit more? It is unclear what the roles are and how troubleshooting works. Also, that a mirror GitHub repo exists etc. Sorry for bothering, but some explanations on the Wiki page may reduce the actual confusion.

Apologies. I've added some more explanation. Feel free to add anymore you feel is unclear.

comment:9 by robe, 5 months ago

Milestone: Sysadmin Contract 2023-ISysadmin Contract 2024-I

Moving my prior still open items to the next proposed Milestone

Note: See TracTickets for help on using tickets.