Opened 16 years ago

Closed 15 years ago

#560 closed enhancement (fixed)

Consider adding a repository validator

Reported by: ksgeograf Owned by: ksgeograf
Priority: medium Milestone: Maestro-2.0
Component: Maestro Version:
Severity: major Keywords:
Cc: External ID:

Description

  • Comments from the original bugreport:

I keep running into problems because column names have changed since I created layers so the mappings are broken, data sources have moved, etc, etc. It would be great if you could build a validator that checked to make sure that all references to other resources, columns, etc, were valid.

-

Yes. That would be a good feature. It would make sense to run it before saving a resource, to alert the user of any mistakes.

It would be a small addition to make it run on a folder or the entire repository.

-

I know there are quite a few users out there who have run into trouble because of bad references or invalid attribute mappings that would love to see this.

Change History (10)

comment:1 by ksgeograf, 16 years ago

Status: newassigned

comment:2 by jbirch, 16 years ago

Type: defectenhancement

comment:3 by ksgeograf, 16 years ago

This is the next feature I will work on in Maestro (Repo validator). This is a potentially endless point, so I will try to keep a list of known problems here. Feel free to add any detail that you wan't Maestro to detect as either a warning or error.

  • FeatureSource:
    • Perform the "Test Connection"
    • Perform a "Describe Schema"
    • Perform a "Get Identitie Columns"
    • Perform a random select.

  • Layer
    • Detect missing featuresource, class, geometry or columns.
    • Detect no scale ranges (warning)
    • Detect no items visible in a scale range.
    • Detect scale ranges with gaps eg. [0-10[ [11-20[ (warning)
    • Try sample rendering, re-test without filter, labels, links or tooltips, to detect errors in these.
    • Try sample rendering with default font and symbols.
  • Map
    • Detect that all layers exist, and their permissions are equvalent to the map.
    • Detect that spatial contexts for layers are within the maps.
    • Warn if coordinate systems are not the same (performance penalty).
    • Warn (error?) if raster layer is not in the same coordinate system.
    • Perhaps check for visibility logic, ea. order should be: rasters, polygon layers, lines, then points.
  • Layout
    • Check that the map exists.
    • Check that the startup is within the map bounds.
  • Fusion
    • Same as layout.

comment:4 by ksgeograf, 15 years ago

The initial version (r3691) is now avalible for testing (and comments): http://trac.osgeo.org/mapguide/wiki/maestro/Downloads

It does not allow running on a folder or resource yet, only on the current open document. A scaled down version that validates the xml of the current resource is run before saving, and notifies the user of warnings or errros.

comment:5 by ksgeograf, 15 years ago

To add:

Validate that property mappings are valid on layers.

comment:6 by ksgeograf, 15 years ago

To add:

A check to see if the extent reported by the provider is the (-1000000,-1000000,1000000,1000000) extent, which is sometimes a masked error, and in any case, not likely to be a valid bound.

comment:7 by jbirch, 15 years ago

In my experience, the GDAL provider always returns these extents for MrSID images; not sure why.

comment:8 by jbirch, 15 years ago

Milestone: Maestro-1.0

comment:9 by ksgeograf, 15 years ago

Milestone: Maestro-1.0Maestro-2.0

comment:10 by ksgeograf, 15 years ago

Resolution: fixed
Status: assignedclosed

More fixes were added in r4104. I have moved the remaining ideas to issue #1058.

Note: See TracTickets for help on using tickets.